Date:   Mon, 15 Nov 2021 12:28:40 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc:     linuxarm@huawei.com, mauro.chehab@huawei.com,
        Beatriz Martins de Carvalho 
        <martinsdecarvalhobeatriz@gmail.com>,
        Deepak R Varma <drv@mailo.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Tom Rix <trix@redhat.com>,
        Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        linux-staging@lists.linux.dev, llvm@lists.linux.dev
Subject: Re: [PATCH 2/3] media: atomisp-gc2235: drop an unused var
Message-ID: <20211115092840.GA26989@kadam>
References: <cover.1636672052.git.mchehab+huawei@kernel.org>
 <81245e1273f2e0e96a520b9d00cd415f65d37b48.1636672052.git.mchehab+huawei@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <81245e1273f2e0e96a520b9d00cd415f65d37b48.1636672052.git.mchehab+huawei@kernel.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z1GedebfnhvQrQrdfqvxkdcpb+e5jX2lf4DGQqu/q3EAKj2KQKTHwrKgr1Tg?=
 =?us-ascii?Q?TEumqVexmti+TtkjtjoBjzBG3BRLuymUiIHjPi0A7lWGAH+kOuWwCOyWcTmt?=
 =?us-ascii?Q?Lhv308xUE25TaLi/2qVSfhiIZRMb5DOgq+2y8SgVLcoDeLoRuNRs9pJYPslQ?=
 =?us-ascii?Q?nvY/997kXZ7n3h4G5JVecBMUuMJZe3oZSlIJ1oUxgM/mdKXpijlCO63KUOSx?=
 =?us-ascii?Q?czobEu9CI6dhAqr2WJfK8p7WAXwkmweIyXYQh4+mY/nS8q+Gc2Jpdlyy0wMJ?=
 =?us-ascii?Q?IgLzsvNpSe93EehQHIeaZRmTk1bt3IRD+FxEehkLc0JZCcw+2/NPf0ox5/q8?=
 =?us-ascii?Q?2Kd9z30CWVRhTtxzIklV071iMg/406aMp+G5umbeJeHmeIVjyEJlF8HmLQo1?=
 =?us-ascii?Q?kZu3cq6vm2T+exYTdyTLwdPrEYXo/oSwvs3GeUXdSdpx/B7MoAaUzl7TG+ue?=
 =?us-ascii?Q?oDZetSgICyv9q8uN8p3fWx3YjcmP2CTN6gZ5B2el3y3d1HiRFAymjqlh/hED?=
 =?us-ascii?Q?ii0g2PM73RxoWrj1hTUG9HByL+CgMgiBc8xnfqSvtA6fhW+FFLBbCml8pd4m?=
 =?us-ascii?Q?dnHvtCHh5ZsOVLa8s3gOrs8FjqubODnW98LJUaWOzVz3K5WXLwC3BxP9DWf4?=
 =?us-ascii?Q?cPGBE6xQoyfq/6XTnuNrst/ZFZJldtHOwguHYONGJOBCf+GuIQikBoWFD1sV?=
 =?us-ascii?Q?64cLMxqfKPVHrnajPkmf1RPxPBjUgqTdWTyKCHqnkgn1MYTCajBZTNn5fPl7?=
 =?us-ascii?Q?iwANKe+GsJ1qQY8Lo7gzvO4cS5Z0IDgpLbewkGvdVlMRbUNJ+zVQzrges4wA?=
 =?us-ascii?Q?/scKSko1dOEw+rOXLgMlNAhxtZg84tVXXNKIt67B3C9I5gsIfGJMmZXao5eL?=
 =?us-ascii?Q?4NrP/oObIXW0e0V/kEN4gnSoBFjUuIoUV3ZCLhJdso3DozRTam94qgA3ueOg?=
 =?us-ascii?Q?jOTHH9K1kV/4EUb8ncXE09IwE/XOxPHIb3s1vhBheHl2uEHYxu0ifrqgQZnc?=
 =?us-ascii?Q?B17SeqT/EW8dX+Z8bujiBvocbsrIhFd1hsdsPP+k94oIboTJTt6tN6amsQwn?=
 =?us-ascii?Q?L74feEZKgTXkccha9svzuXA5YeFO6pZ2YaJ84jAi46clb7G/Fgux16sRu/4a?=
 =?us-ascii?Q?axMgHMiy7p6LwGMDcXf5jtLr0u9iJOL3rk2wcyi3Nv7EmtDafC4Eww4UjMEM?=
 =?us-ascii?Q?halVTJghEWrpf2U5K/W+AFRQjbjgcOvg78wFGpFpZ5ySrsogUS07EmbNcHmG?=
 =?us-ascii?Q?e3LILctnamPpznNGA4N8qiOVGlwk2hPYzlGl0TJTelKRYndGfyn3+uOAMNFi?=
 =?us-ascii?Q?RdVWPG03axiqNSkXeWVOCbMgt9FzOYiAMg0U1PDgi+uHdxOvYb0zRGqEJx+Y?=
 =?us-ascii?Q?nHP/ksiamAjuldnvq0p+z+GGVsvxj0XNWlV3d36qyG2fVF6WanCS4uR4Vosk?=
 =?us-ascii?Q?nTiov8n9ynRF8W3lTW68pPp3tImAiilAcx8aBRf5cWamouHyTXKcSBv72q7X?=
 =?us-ascii?Q?XkKGvI6ggRA5JMK997i1u+LGe82oYOK/jnir1yfN3bU6s08K1CXssqPhViz+?=
 =?us-ascii?Q?s+UeIUPyL+Jn+fiHckEWFJUJTinHcMIPPeKTn2mZ/LpENFpSE9zv4JHSrDo/?=
 =?us-ascii?Q?8oqUpHqHacjtbelCv/wbHJfD8GXokgl04jRAHpdnd71FpkFo/bnzc6ouniat?=
 =?us-ascii?Q?0BVA+1W8KZ01CDmYBbY2Ph4kFHA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48bdd10c-e80c-4b08-9ddc-08d9a81a6985
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 09:29:25.7527
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3z8CinB8VMuzg6EnKfTGV4lZbFQqpiVzk7aYu0vZ81ZVj0q8GhhpxxjpSHiFCitvD9x3ZEYpRbYQqqT7C0dT6JhaYqPpYDmrTeCeXCVMIbk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1951
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10168 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0
 adultscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111150054
X-Proofpoint-GUID: lbxeHk2CcAb98cNrE78tZwJYn9OMPOiz
X-Proofpoint-ORIG-GUID: lbxeHk2CcAb98cNrE78tZwJYn9OMPOiz
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 11, 2021 at 11:08:52PM +0000, Mauro Carvalho Chehab wrote:
> Fix this clang Werror with W=1:
> 
> drivers/staging/media/atomisp/i2c/atomisp-gc2235.c:573:6: error: variable 'ret' set but not used [-Werror,-Wunused-but-set-variable]
>         int ret = -1;
>             ^
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> 

Looks good.

There should be warning for "int x = -1;" followed by |= because that's
a no-op OR assignment.

I'm surprised that clang doesn't print errors about the other
implementations of power_ctrl().

drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c
   448  static int power_ctrl(struct v4l2_subdev *sd, bool flag)
   449  {
   450          int ret;
   451          struct mt9m114_device *dev = to_mt9m114_sensor(sd);
   452  
   453          if (!dev || !dev->platform_data)
   454                  return -ENODEV;
   455  
   456          if (flag) {
   457                  ret = dev->platform_data->v2p8_ctrl(sd, 1);
   458                  if (ret == 0) {
   459                          ret = dev->platform_data->v1p8_ctrl(sd, 1);
   460                          if (ret)
   461                                  ret = dev->platform_data->v2p8_ctrl(sd, 0);
   462                  }
   463          } else {
   464                  ret = dev->platform_data->v2p8_ctrl(sd, 0);
   465                  ret = dev->platform_data->v1p8_ctrl(sd, 0);
                        ^^^^^^

   466          }
   467          return ret;
   468  }
   469  
   470  static int gpio_ctrl(struct v4l2_subdev *sd, bool flag)
   471  {
   472          int ret;
   473          struct mt9m114_device *dev = to_mt9m114_sensor(sd);
   474  
   475          if (!dev || !dev->platform_data)
   476                  return -ENODEV;
   477  
   478          /*
   479           * Note: current modules wire only one GPIO signal (RESET#),
   480           * but the schematic wires up two to the connector.  BIOS
   481           * versions have been unfortunately inconsistent with which
   482           * ACPI index RESET# is on, so hit both
   483           */
   484  
   485          if (flag) {
   486                  ret = dev->platform_data->gpio0_ctrl(sd, 0);
   487                  ret = dev->platform_data->gpio1_ctrl(sd, 0);
                        ^^^^^^^

   488                  msleep(60);
   489                  ret |= dev->platform_data->gpio0_ctrl(sd, 1);
   490                  ret |= dev->platform_data->gpio1_ctrl(sd, 1);
   491          } else {

regards,
dan carpenter