Date:   Mon, 15 Nov 2021 12:50:13 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc:     linuxarm@huawei.com, mauro.chehab@huawei.com,
        Deepak R Varma <drv@mailo.com>,
        Ding Xiang <dingxiang@cmss.chinamobile.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Robert Foss <robert.foss@linaro.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Yang Li <abaci-bugfix@linux.alibaba.com>,
        Zheng Yongjun <zhengyongjun3@huawei.com>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        linux-staging@lists.linux.dev, llvm@lists.linux.dev
Subject: Re: [PATCH 3/3] media: atomisp: handle errors at
 sh_css_create_isp_params()
Message-ID: <20211115095012.GB26989@kadam>
References: <cover.1636672052.git.mchehab+huawei@kernel.org>
 <f1157236eacdaab3def9b7d18f1c2e7ef9a3699d.1636672052.git.mchehab+huawei@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f1157236eacdaab3def9b7d18f1c2e7ef9a3699d.1636672052.git.mchehab+huawei@kernel.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?N/MnGi8sVBYKlEpbhqzQAVBZcrRaqEIiunDZzMQNeN2t3Uyn4+vFxajH8fxa?=
 =?us-ascii?Q?a/Yy4gYdyxQmTmPa9fQ5o/Qz67YCOcMGuhaDVkc3dQxo3rVBmlNrEgogUOqo?=
 =?us-ascii?Q?icPDCbDJ/TW3DFDdkOXN0JGZokqHotJTb1ygtlnzGjdWPKFBri0zyNlRDeyk?=
 =?us-ascii?Q?E+MlaXxpJmxYXiRUQ5EQov7TNb75vzu4KCQqzkmFvoUv5QTXxm+S2BB1IcBG?=
 =?us-ascii?Q?KHbZUjsGo7QCknWqOGA79j9UVaDV4pQD5REXU2Ct1A5DAfgsZ3bNKzi2kddW?=
 =?us-ascii?Q?h+jYKDOoRM07y8u0DQi8HWbyUMqKef/PxFv6ZvWqISJLDSmri4j5h70iNgQz?=
 =?us-ascii?Q?7p7DB44SoAMW8WbFiT11T6fW9GF+xSGHytrYk/ke9P1I449mcar8T+In3PyT?=
 =?us-ascii?Q?M8GYnYsXwDltjZ7EmAhQvnSRq4LRC0YJAnYTqYt01FvQtznrXWS4LyZ/yrIR?=
 =?us-ascii?Q?tRYnzAiB4OAbgSxCdu3xwVG2yGQg1eNDYvoySV9MT1Ac1yo1vTm7GrY5C6WA?=
 =?us-ascii?Q?Qy7oB/SnoTpxucniMWK2Ul2Nby0efHVbp1n5VJIlaFUuuTXVaaJKI01DEx7q?=
 =?us-ascii?Q?zgpYTDDQtTxTRObO3hh5cZjm28OGJRGD5vs25Nzv/cI5QSGZpeMIwpc+yM9c?=
 =?us-ascii?Q?IYHulo4tZSCOybutc5pMEoRWOkGr0i16k67x6lWeO/dD7M4RJL7XeD/+w0+d?=
 =?us-ascii?Q?Rt0LTFdk67qEgZ5SO6vsf2jMY/4oHeq2SvKpkRrU+PVusI0Ni6mqG57SHfvv?=
 =?us-ascii?Q?1u9DvJ3WvRaYTqvG1r2EsHnwn71pala03EBMrVr7U6VFKlw4JkKVYwFAgoVJ?=
 =?us-ascii?Q?6E3hyEWohyT8spaZXgjmQcxMSEXRGi8+vik0E+QTdACJ5z6EpNRrIl2aKULN?=
 =?us-ascii?Q?ooZl2rTnl9UJZ4skzWo2xU9JbncIvUOkXM81kkTUbguDC7QXg0qE+7kD3FSR?=
 =?us-ascii?Q?o73x7fIvVHBRAsTYGouSaVHjfyHVN9zjuGK3h8vkl6QjAuMPst+AkLaguQJd?=
 =?us-ascii?Q?uIWpLTj8+BepM4lHZFSx9OCm/lsvU8mbUNen4CRWaIJ+P60d5dGn0Y9PrG8M?=
 =?us-ascii?Q?Zlw5jhJj1MxQ5gF5ypLnqf806cqpTYuOD8mK2EkleXl871RwfKYwm3Sf6S7+?=
 =?us-ascii?Q?MQvROdz9pXvF5aeUOF6FNzzh0CjwdH/o3qnSauXsX6JVlhNJWPzYoRw446WS?=
 =?us-ascii?Q?lyx0NN+x79NIzoDGD3GRgPloz8E4LcGMk12gQXAuqusuk5UDSoJ9lFczDbeN?=
 =?us-ascii?Q?D33/J4Ne406k1JN+xkmVMxxehau7dyIaLokmj2UBaMGd29tjXn2dqMe0ZHO5?=
 =?us-ascii?Q?EKrC14UcgGMQPmmGz9H4uA7MqdSUsk/soSaeNXC+o6snVIf0e4say9+4zF0e?=
 =?us-ascii?Q?ZrZ44CldlYUWlJw+tuacUS8erx9Gk3AulORQ2SeAHvMrCm5nDHJogfmYB+VJ?=
 =?us-ascii?Q?NcEtWdxVP9MMPTd6ii9CPL1qP7XQnoTEsDEXfYHOAGt2W782iuO1UhlTtAY9?=
 =?us-ascii?Q?b/F98/+ReFgg0Bg5yJ2lJP4wyWYycXP0eMh0qjLhkjVW7nbC1RjZ/JNVSoDB?=
 =?us-ascii?Q?r+8JFzx8rBu2SdpA1/t056vpVTS65rIDTOXY7GLaWF4FoDufqoHPkbFoY5JZ?=
 =?us-ascii?Q?VbnR33Hzt41ioMcpmKcUhdNVS5liZnEBLeKwtHLZVNJ5Zxgmj+mI7mi+KrLX?=
 =?us-ascii?Q?EaGpoqyaRzGaj4za5PVBx039+oM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 007f5f15-57d0-4f1d-8eb3-08d9a81d6156
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 09:50:39.5033
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4HVR5D8mKnoY/WonnIrZ9Ye/11qp9ue4BX4GUoANboUG2cNC+D/4evWgBTFIU9U4V5SmNn/1y5MTcUNbfoXcBpaPLKJctCm+FqRSUzKsjjk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2253
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10168 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0
 adultscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111150055
X-Proofpoint-GUID: vkoQO_ov-pu2pScFOjTNP3dzaGpCtWGg
X-Proofpoint-ORIG-GUID: vkoQO_ov-pu2pScFOjTNP3dzaGpCtWGg
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 11, 2021 at 11:08:53PM +0000, Mauro Carvalho Chehab wrote:
> The succ var tracks memory allocation erros on this function.
> 
> Fix it, in order to stop this W=1 Werror in clang:
> 
> drivers/staging/media/atomisp/pci/sh_css_params.c:2430:7: error: variable 'succ' set but not used [-Werror,-Wunused-but-set-variable]
>         bool succ = true;
>              ^
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
> 
> To mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 0/3] at: https://lore.kernel.org/all/cover.1636672052.git.mchehab+huawei@kernel.org/
> 
>  drivers/staging/media/atomisp/pci/sh_css_params.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_params.c b/drivers/staging/media/atomisp/pci/sh_css_params.c
> index dbd3bfe3d343..3cc5b82a8a31 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_params.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_params.c
> @@ -2473,6 +2473,10 @@ sh_css_create_isp_params(struct ia_css_stream *stream,
>  	succ &= (ddr_ptrs->macc_tbl != mmgr_NULL);
>  
>  	*isp_params_out = params;
> +
> +	if (!succ)
> +		return -ENOMEM;
> +
>  	return err;

Better to "return 0;"


regards,
dan carpenter