Date:   Mon, 15 Nov 2021 10:59:46 +0100
From:   Gerd Hoffmann <kraxel@redhat.com>
To:     Lukas Wunner <lukas@wunner.de>
Cc:     "Michael S. Tsirkin" <mst@redhat.com>, linux-pci@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pciehp: fast unplug for virtual machines
Message-ID: <20211115095946.54tp5glmgfged3rz@sirius.home.kraxel.org>
References: <20211111090225.946381-1-kraxel@redhat.com>
 <20211114163958.GA7211@wunner.de>
 <20211114122249-mutt-send-email-mst@kernel.org>
 <20211114180604.GA23907@wunner.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211114180604.GA23907@wunner.de>
Precedence: bulk

  Hi,

> > This requires guest specific code though. Emulating the attention button
> > works in a guest independent way.
> 
> It sounds like you're using the Attention Button because it does
> almost, but not quite what you want for your specific use case.

Well, we want send a request to the guest to shutdown and poweroff the
device.

> Why don't you just trigger surprise-removal from outside the guest?

To give the guest a chance to shutdown the device gracefully?
Umount filesystems, flush data to disk.

Also guest stability.  Traditionally linux isn't very good at dealing
with surprise removal, although the situation is improving.

Emulating surprise-removal has been discussed too.  More as fallback
in case the guest doesn't respond to the attention button.  Right now
we don't have it but should be doable.  For some kinds of devices it
shouldn't be a problem to go straight to surprise-removal.

I'll go experiment with that.

take care,
  Gerd