Message-ID: <6be8285f-6cbe-c115-a826-585664c91022@suse.com>
Date:   Mon, 15 Nov 2021 11:08:22 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH] xen: don't continue xenstore initialization in case of
 errors
Content-Language: en-US
To:     Stefano Stabellini <sstabellini@kernel.org>
Cc:     boris.ostrovsky@oracle.com, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org,
        Stefano Stabellini <stefano.stabellini@xilinx.com>,
        Stable@vger.kernel.org, jgross@suse.com
References: <20211112214709.1763928-1-sstabellini@kernel.org>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211112214709.1763928-1-sstabellini@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3VDeDNEYVpkbGhJRUZnMzVja1Z0em9JKzBNbFV3d0NnZVN0aklJUElvS2li?=
 =?utf-8?B?b3BaZWFETWk3U0NWcHViV3QzSXVDWDVNZ0FCVzNzdzNuNll0QUtDQS9jSUw5?=
 =?utf-8?B?WGloQXFieWdEaG9uU3NRajJXbFV2UnBTaFBvZDlNV2JLc1VxUTJ6ZzhDdkRv?=
 =?utf-8?B?WlZsUHpZelBsT3J3Z0FkaGZheC9kSHNySGpIN2F6ZythS20xWWZxa1F2V0hR?=
 =?utf-8?B?Ulc0eVg3UERTV1ZjWHVlbnpMa3dqYnFDeXJjY1FPcXhSME1zbHZxbmVOdTNw?=
 =?utf-8?B?YStSbW53NGt4bUl2c2UyU3VUZjNBaWljRE5JQkFocHFVcGl6QVoyUFVqSlRx?=
 =?utf-8?B?bG1JN0hsWEF2SnVNaG5DbzdsYWlDZ280WC9hdDBOUEZ1Sk8vU0Y5bEhucTRG?=
 =?utf-8?B?RUF2dG4zM0tjWUFsbTFIcmt5TENOOFBHdWtORndLYnM0V0F5dW5ZSkVPR015?=
 =?utf-8?B?ZWlhbU5yMC9IeDVxQ2FDWXVwOU51d3l1Vmk5S1N0Zm41cDRDcTd4cHZEMzZ0?=
 =?utf-8?B?bmpjRnZmU2Y2NzZsdzdxa0R6SEc1SFhlMFdlcWR5SXpwUmdsWHdBbDFxRThl?=
 =?utf-8?B?R3R6NDVuNzlsSktsa2JyU21pM3p6ZE1SUjZ4SUxoc1NSOHpza3RUcXNTREFL?=
 =?utf-8?B?Q1BtZnZWRVBvL3E5MjNqa2FCWnN6bzZJcWZ3S21YdTRQVm1HcENubXB4WEU3?=
 =?utf-8?B?WlhOVmxLakFZUmE5UmlVVHprcGNoUi9UUndiekdQR2tyOUl1OFRSM1ZXSVdV?=
 =?utf-8?B?ZE1rVVczSTViTGJ3Z3dRRCt3MnMrU3pydkZtTm1QQitjbDVzM2pzd2pnVjY4?=
 =?utf-8?B?SDUraExRaUVWcTV5M0g2NmhTUUxWMVcvdFVLbDV3T3VNcm9nM1hMTzkvWkRZ?=
 =?utf-8?B?RDNyWjNsNG5EeDhGd1VVNlA5aEQzYXkwL0RLdFMrZmczMTgxTUIwSkVnbUtD?=
 =?utf-8?B?ZGdiU3p2WXFvRTZGNUh4NEhzNzBKRDYzRFJ1VldkdmYwbC8xV3UrdkJ2WHha?=
 =?utf-8?B?U2dJYWRVbEI0Yk9pUU8ybzh3WExhdkprZVBWbTlqbE54UHVja010dkkveUJP?=
 =?utf-8?B?L0ltMnhwY0ZHNERLYnFtSjJSc2FJUEhwSW9QOFhWSnArZUhoOStaV204Nys4?=
 =?utf-8?B?Q2NNdElPaGRuWnNheWtySFZLQlFnckNBTFhldHQ5V2hxNU1nZnNwR0Q0UGFB?=
 =?utf-8?B?RHJZZm9PTS9XWGNsNWhCRGlaTGpEN1BFMlVlUEVVOXFud0FWdTE2TlJ3TGtS?=
 =?utf-8?B?Mm1SK3BYcFNEdVRndFczamNOM0RJdGdOOTRoM3IzU00wZWh4Ti9Ndm05b0lH?=
 =?utf-8?B?R2tZTkNEVi83TUU5Q1NDMDIyWHJYRTg1UE1ZdUtUVFFFOUhXSFg3Y0lHL3JD?=
 =?utf-8?B?Ti9Zek1CeEVjZGRTQTlzTVQyeWdhV3M4QlVuVjV1Ni91UmhPdHpBUmM2bTBW?=
 =?utf-8?B?N0VqRHRoZHV4M25mWmpFTFZDM3M1anNaYUsrMFlLbG9zMEdjSXZLOTk4R1dj?=
 =?utf-8?B?M2N4YmdnM1JMdW83aVZYd1JGdlRPS05JWk55L2F6T3JsVDRiajlKMUI1Vnhp?=
 =?utf-8?B?KzdZREZoMlZXU2hLQlozdXdRVGx2amh3S0hrUGd3MFAzRnF4WTZUUWlLZFlN?=
 =?utf-8?B?V3dBekF0WlBDaHBFbXk2NnQ0dVV5QmJyZWp3SEhOOUJkUVhhU3R1OG12dzRN?=
 =?utf-8?B?aXEzZjFyaVJTTnNqdzl3QnE5RlUwZUorOE40cnpvdFBKZ3lvbjdsVUFUSXFD?=
 =?utf-8?B?UlVYa3FIVFJDTFVyTktzVUdMUzg3ZkkwWHFVZVNKbGNOL0xLbGZvSDlsSW5w?=
 =?utf-8?B?WHZPRzBHV0M4VEFWV1FITTVNR0Q2SHJSV09wbXFmZ2h1MVRrVXNBQ1B0Wnl5?=
 =?utf-8?B?dFBDSmRvRnNqUHcvc2Z1b0RQeVhVR044TEU2TExwVlk1a0pLSjlHMWxTZllq?=
 =?utf-8?B?ZGlVa2ZKNnh3RHh6M0JtajRLalkrUHlVOVdSMnA3OG9OWWcwd2dwT2RIZTNB?=
 =?utf-8?B?RGtVdWVRcy8xU1NvY1ZJVXdwUlc0UTJ2MUxRbGZFbStUTElHN1dVZERNeVov?=
 =?utf-8?B?NWZiS1VEOEE2Qlg0RmlUNFY3alNlRnZUVTIwdSsvQlIwU1QvM1JQaXBOT3lv?=
 =?utf-8?B?UXR5bGt3RGZFNktpakNzK2tzZVE2ekFLWkdnTE1oWVBxMmZxMHk5VHBpWU5n?=
 =?utf-8?Q?f+rwsoCmNoDxyJk0f/p1x/g=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5d1593c-539b-418f-915f-08d9a81fdae0
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB5587.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 10:08:22.0607
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9yV5vA0DTj27W3huiJYd7topd851w+8vJMRHY6t4cusjuhtKFdM25sXzvk1LXMeIFLmKZp1xxUUeEDWCbZe2ug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4145
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12.11.2021 22:47, Stefano Stabellini wrote:
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -983,8 +983,10 @@ static int __init xenbus_init(void)
>  	 */
>  	proc_create_mount_point("xen");
>  #endif
> +	return err;

Personally I think such cases would better be "return 0". With
that done here, err's initializer could (imo should) then also
be dropped.

Jan

>  out_error:
> +	xen_store_domain_type = XS_UNKNOWN;
>  	return err;
>  }
>  
>