Date:   Mon, 15 Nov 2021 11:09:43 +0100
From:   Gerd Hoffmann <kraxel@redhat.com>
To:     Lukas Wunner <lukas@wunner.de>
Cc:     linux-pci@vger.kernel.org, mst@redhat.com,
        Bjorn Helgaas <bhelgaas@google.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pciehp: fast unplug for virtual machines
Message-ID: <20211115100943.ezvirlrxc2qzms3i@sirius.home.kraxel.org>
References: <20211111090225.946381-1-kraxel@redhat.com>
 <20211114163958.GA7211@wunner.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211114163958.GA7211@wunner.de>
Precedence: bulk

  Hi,

> Same for the 1 second delay in remove_board().  That's mandated by
> PCIe r5.0, sec. 6.7.1.8, but it's only observed if a Power Controller
> is present.  So just clear the Power Controller Present bit in the
> Slot Capabilities register and the delay is gone.

Well, the power control bit is a useful data channel.  qemu can use that
to figure whenever the guest uses the device (power is on) or not (power
is off).  And in case power is off anyway we can simply remove the
device without the attention button dance.

take care,
  Gerd