From:   "Chindris, Mihail" <Mihail.Chindris@analog.com>
To:     Jonathan Cameron <jic23@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        "Sa, Nuno" <Nuno.Sa@analog.com>,
        "Bogdan, Dragos" <Dragos.Bogdan@analog.com>,
        "alexandru.ardelean@analog.com" <alexandru.ardelean@analog.com>
Subject: RE: [PATCH v5 2/2] drivers:iio:dac: Add AD3552R driver support
Thread-Topic: [PATCH v5 2/2] drivers:iio:dac: Add AD3552R driver support
Thread-Index: AQHX1Ho57nuMSHzMWEG/6CFZIEaVkqwDCEaAgAF2WDA=
Date:   Mon, 15 Nov 2021 11:31:52 +0000
Message-ID: <SN4PR03MB6799D1FA928E3F712E3799A599989@SN4PR03MB6799.namprd03.prod.outlook.com>
References: <20211108082447.116663-1-mihail.chindris@analog.com>
        <20211108082447.116663-3-mihail.chindris@analog.com>
 <20211114130745.6ba386a1@jic23-huawei>
In-Reply-To: <20211114130745.6ba386a1@jic23-huawei>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lM4yPo2mMeCaFpdugNd7JxEeg0Hc9nLoAZBjJbtyxxjKeYhluOxzp8jqt7xY?=
 =?us-ascii?Q?5qTNjsglD5Bc+QD9zsX7s/4n7OGEW/NF4REBB/7NzFx34Nn489n8+mAyl1z1?=
 =?us-ascii?Q?EnEefUVQEIqe3nuCOhYBocw/UiSKBM64Urywan/sFkAPFUC/w1w0c2IFtQoa?=
 =?us-ascii?Q?iWj9Yl/HkjCaa4fl3bH1/YXVM3K1I2rHbvu3FhQNyCyUK1VKz6mRNGTHnsI/?=
 =?us-ascii?Q?2xZpTS9vaHtSxMi03mVzkLMw+zT/sNcmmRsiTiSS+x0gDarDgKzvPHGcDrtX?=
 =?us-ascii?Q?Xm1OmL/JJkCtiqnXQ+OH/ro1EF6uXh3rkBEBAPEvHm8qpJu/sIqctl9GCyfx?=
 =?us-ascii?Q?c/3Q7Pb6+q4xRE5VBUet1AezDQRFln5dejYxTKRiy70FeJax8h0MruBtTIwB?=
 =?us-ascii?Q?nZ5lZ22h9wUPHjTWRJsFo4iZH1D7ZXchKV1+N/zCwCWfDt3TNuxgtqjVgTYJ?=
 =?us-ascii?Q?X39qI0I0njD3cbv/H5+EyfmX4HAsp3N3tAw1yhG+6/jgwLJVbjoNNp+prmz1?=
 =?us-ascii?Q?G8uH4LApd9bJoqcQiqFVm73fRLCF+JG2GA3RGRunuFxDr51SGCaRH55cYi/Y?=
 =?us-ascii?Q?m3XHEwfO8zDtrpbOXgd/jHrRC/qsQ+SwsfAdAMY/e/Mg4sbBRGp6Fh0mY/+0?=
 =?us-ascii?Q?ufbg2gWT+mHr2qrdIoxfPKjxGlCOdqK0gjW7UGC859fS0XJDeIP/XpZUFipo?=
 =?us-ascii?Q?rTd0YQfavCyKlCWp0y5ihSt/G1GshLzYk/rZ3YQQXkPkP2idqjYI33VSC7Ij?=
 =?us-ascii?Q?ssU1WvWkBbvpImxY1kaIik6XanYHlwOE1Jfq/AbuZFJSRc9BIBIdhNPmop9d?=
 =?us-ascii?Q?RaaaqBlaDohhDa/8rPXoHROyOjZOUn0Yom5H+XyJh4DcTLd7Z4TdFuhVDDkq?=
 =?us-ascii?Q?L+WZqKOd/CsrKcFknhdbC9XDK5E5q0o9wElseEy7aQe69Kl0UXPUodNIgg7m?=
 =?us-ascii?Q?V3STn6+2+3MXoeNr0ts5B/rG++tdTZGRtV70iR3l9R1sSLU5rHqMpd5nO1Dz?=
 =?us-ascii?Q?KfZnl8b/afeq0HaB03bMPerGF3k4HRtePelRhreeJwaI0eBpMAwA8s7yKf4W?=
 =?us-ascii?Q?DXTUMGv4QC0nopvwJ6xfHULqozYrBQkJM+2bkpLlEVsiSRmL/ObxrOxAIRNH?=
 =?us-ascii?Q?tXZwgaEFtbzBhku0oE1ixNpwSnJC9M7OtPcNd+aa5BGfsegXrZUvw+5XorEw?=
 =?us-ascii?Q?lGjwxTYBw8M7cQ6ghY1jX5ZGP94eWf4+PGZksGQqc6zYXT0tYqZaTOx6SL4D?=
 =?us-ascii?Q?4mB7Kwz1tONrniKBRSY+/EyZeNySW4xaW+aWZlr67VU6gjSRF9pjEK0MrdoM?=
 =?us-ascii?Q?e2LPPTHX9zBZ09T6dvg+pjY42DnYEPnzF9+PviCbbsZy3mu6kousONjQv4O0?=
 =?us-ascii?Q?FSnpG/Sow5s3cjjO5W3ITHIYhWNa4b+UwwTK3hVE8lzipYBBkbRJ+ZD5s56e?=
 =?us-ascii?Q?yGA56DvTgSMlW+R4fvCNo5n+TkW55Xs62g405jPjd+Zm96AcB1UJv2lGDHh0?=
 =?us-ascii?Q?udAuGcHcHRPyblgZb2TKmsfQmcAPWip9IaJwlernmaOahrDFdr/D4tScSPEu?=
 =?us-ascii?Q?GYFZHw0jFbw6PBsq2lAogt3e26ZJQ6pVo6mP6CYiJVjOGU8qroDJyYBj1wir?=
 =?us-ascii?Q?vy2xz/GAVJwxIRs6NqC71M8Qrp2PL+jQHtZzdLmqSLKPLv8U2n38ZbII+Lku?=
 =?us-ascii?Q?WaXPZ9ll2IHouf3gx8d91ttyWyVbMTrlgXlVDAOhYNUXIF88nmxXb+AwXi8q?=
 =?us-ascii?Q?ZzVIjKXbXA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN4PR03MB6799.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 048992ec-e71d-4e7b-ca95-08d9a82b8549
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2021 11:31:52.0870
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AIG078qz6fhgxsn5q4eq0SHBMhcnlX8I4rawjBDsVO9NJHOXFjBoshdKTU0btzvS8Ahht2YIdpSNqJfN7FBceR1VnoYFQa9D5KA5saqHYCI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6595
X-Proofpoint-GUID: eJZKMISHpHOQBV2XNW6-EMySnswrOlnq
X-Proofpoint-ORIG-GUID: eJZKMISHpHOQBV2XNW6-EMySnswrOlnq
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-11-15_10,2021-11-15_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 mlxlogscore=999 bulkscore=0 suspectscore=0 priorityscore=1501 spamscore=0
 adultscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2111150063
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > The AD3552R-16 is a low drift ultrafast, 16-bit accuracy, current
> > output digital-to-analog converter (DAC) designed to generate multiple
> > output voltage span ranges.
> > The AD3552R-16 operates with a fixed 2.5V reference.
> >
> > Datasheet:
> > https://www.analog.com/media/en/technical-documentation/data-
> sheets/ad
> > 3552r.pdf
> >
> > Signed-off-by: Mihail Chindris <mihail.chindris@analog.com>
>=20
> Hi Mihail,
>=20
> Main thing here is to give time for Rob and others to take a look at the =
dt-
> binding but in meantime I thought I'd give the driver one last look and
> spotted a few minor things.
>=20
> Jonathan
>=20
Hi Jonathan

As per Lars' comment, it seems that the issue was similar and if I understo=
od correctly the replay, it seems that the naming is ok.
Anyway, I implemented your latest suggestions locally and I will wait for a=
 feedback on the device tree to send the new version.

Mihail

...