Date:   Mon, 15 Nov 2021 15:35:34 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     roopa@nvidia.com, nikolay@nvidia.com, davem@davemloft.net,
        kuba@kernel.org, bridge@lists.linux-foundation.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net: bridge: Slightly optimize 'find_portno()'
Message-ID: <20211115123534.GD26989@kadam>
References: <00c39d09c8df7ad0673bf2043f6566d6ef08b789.1636916479.git.christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <00c39d09c8df7ad0673bf2043f6566d6ef08b789.1636916479.git.christophe.jaillet@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7NNX1S3jcP7e614OkalcUZ75H1/F4QKtXPLYiv7zvtP96vSeIwC892rFwcB7?=
 =?us-ascii?Q?8KXmM4YZFFqQw2hTnPJqHEQAX4A1J3SG8qcjh8RwnJk8bODdb9Gr0AbXh8tR?=
 =?us-ascii?Q?yTO4qWgxtnerVpwUk5Hwqlh39tRqHk/lkrjYUYCntfpI9Jgvkh/DY1578jcv?=
 =?us-ascii?Q?ky2W9UngrFKGOKVwJIbQ75tTYp+BqOfc1C8hJJt5sx+5OtIANYz+RGnZMvjv?=
 =?us-ascii?Q?T1uAK+pR/4k1Jo/FY2JmKE7kSpFzEje4wwvOf7WKaccUEqnQImZWFtCWe4FC?=
 =?us-ascii?Q?uYu0OM5/BhhNhbpxyIC+Witg3vIRCyFLn3rogZ+LtqFDUXaKT1NuzKaARBtd?=
 =?us-ascii?Q?lLnhDGB7Qu4qhtg2Q7MPOiSRSSlWOlem2VLAZhbgxfLuls7gOAy6o2Pf7HoG?=
 =?us-ascii?Q?ySmf20TV3VFnup/dH/ZBeoPnSwtKUt3gD0zA/EphNcBOQpETUxw/fCxhLD/7?=
 =?us-ascii?Q?IbVm6g1vi/DhP+Lhh0jq8p3k1FD4rAQ9J5zK5uh9Pm8dbYhL1hgcbhwLUTt9?=
 =?us-ascii?Q?M4tI3Ac07AIxTUUL5IY+acZBGpNKO7pozVnhdZ6XiNz26mDvp7sL8bM/UimJ?=
 =?us-ascii?Q?Ez+EqTKXQnh5mwiG7po7JmQiW7vKX92F20s2vb69mv8Sri4xOT6D9Mnlnsx8?=
 =?us-ascii?Q?e4Em+4d7OUhyKU2eI0pzO3bzirn9ORn/bdaptBo7SgSJ5vE2Kbd3vSloUcRr?=
 =?us-ascii?Q?UwjFpQEEeao9Kptgz8RC2mOZa78Dt+vw2Iy/bA4eWIwD9K2QdXwzdKpMLAFA?=
 =?us-ascii?Q?NE/rvyIKVqwVNQrVp4p/Oz/xtcBv10QtpcY2T2+Z/HSsO7eTIAKBEDIgA8wH?=
 =?us-ascii?Q?qIMKeb2MdliORfDKAKDtYr+S+GIlz/lfhZ5Ubti+bR9AYISC/f9LyyjkuUK3?=
 =?us-ascii?Q?L6rJa/vF86Iur3j3HjMBQTF/0bINs4jFCj3qmZL8SW0ReqmP8s7RNF5KoqkF?=
 =?us-ascii?Q?mM2FgKPi268synjnM9+AItCsP0CCoNJzw0e4fFScTz+dy+B+ZkHcF+90lEEA?=
 =?us-ascii?Q?2NICY6y8PB3oTk0D9K3k3enwxww35HYf7vMwUtcdTAVq3zVHcOxgp9ythiGE?=
 =?us-ascii?Q?kI0KqT1vvIGbIc4RnL7S2R4QbPF60jWggchgEoUl2Z2HhdzjNgPVof8DlApp?=
 =?us-ascii?Q?gNKy362+VCYM9GtHmVWEYbIpKS8zWNnRfh7bTyoh6tCrkq+NekLRRFu7vbVc?=
 =?us-ascii?Q?OKqfuS/dViuZj5UbgyO4/QtKjGwVW4pOMx54elSUwTcgb6W5iUdUVkKCy/Cm?=
 =?us-ascii?Q?+W5C+9NI0WxG1zm0JQ/wT+0XNFwl7utc8etjuhy0J0Qkzv/HCm9Bd4zsiQXf?=
 =?us-ascii?Q?9ro4QYO0Pwm8cpS4+k05/Kv9?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d102a9b5-46f4-4f96-dfc2-08d9a83478c2
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 12:35:56.9217
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s7dQdkHaYpXHesvvCeIE+CGZSMYqMa4Xx9ybd8JGNbKTn3PwkRKdA4UzLLbiOSieApWQeva8yZ6t0GNrLCg94JsyN0+k5wQXryrQQyNaHOc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5714
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10168 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 bulkscore=0
 adultscore=0 mlxlogscore=632 malwarescore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111150069
X-Proofpoint-ORIG-GUID: VTO7nmzC3Y2nw9AL3JYn00HqFiGniStS
X-Proofpoint-GUID: VTO7nmzC3Y2nw9AL3JYn00HqFiGniStS
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Nov 14, 2021 at 08:02:35PM +0100, Christophe JAILLET wrote:
> The 'inuse' bitmap is local to this function. So we can use the
> non-atomic '__set_bit()' to save a few cycles.
> 
> While at it, also remove some useless {}.

I like the {} and tend to add it in new code.  There isn't a rule about
this one way or the other.

regards,
dan carpenter