Date:   Mon, 15 Nov 2021 09:31:07 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Lu Baolu <baolu.lu@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Joerg Roedel <joro@8bytes.org>,
        Alex Williamson <alex.williamson@redhat.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>,
        Chaitanya Kulkarni <kch@nvidia.com>, kvm@vger.kernel.org,
        rafael@kernel.org, linux-pci@vger.kernel.org,
        Cornelia Huck <cohuck@redhat.com>,
        linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Diana Craciun <diana.craciun@oss.nxp.com>,
        Will Deacon <will@kernel.org>
Subject: Re: [PATCH 03/11] PCI: pci_stub: Suppress kernel DMA ownership
 auto-claiming
Message-ID: <20211115133107.GB2379906@nvidia.com>
References: <20211115020552.2378167-1-baolu.lu@linux.intel.com>
 <20211115020552.2378167-4-baolu.lu@linux.intel.com>
 <YZJe1jquP+osF+Wn@infradead.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YZJe1jquP+osF+Wn@infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/95oejYvv8deT98VlAe+HKwPS7KhzFi30g0i8HFvo3J6uJ71VrnjhRUMiWve?=
 =?us-ascii?Q?SO75J1HbHqWYmli0uABO8gxpddDxFRMPxj+3wd4ypa0O+EmA0Q0HAbWmDpJk?=
 =?us-ascii?Q?cfuUzzKNJW6BHjjOHB942MmK6blEFKncGp2m/8GkjhDknGTjiENf/lBU+FLd?=
 =?us-ascii?Q?JCgbAz2chvkGwZp/e0GahYeXyQ/JR2IB4B8D2J521Ona00uXSRFOfKS1xHsz?=
 =?us-ascii?Q?XHXG8D7eAqVkeQV56CBG/pXrIzD2fPrnICdA2tZphnTIS1c8dL7220KoLzgm?=
 =?us-ascii?Q?4Om5VDVP7573B3eutagxzAZFZUMHS7ifdNPeXlZckCmrgxUCUKlmrcZgzecv?=
 =?us-ascii?Q?xBD2uLpvbxiHPwQeplTkaAujKUO4HkrhF4VfkfAiQmDjs20NI/PXLim3D/Xu?=
 =?us-ascii?Q?8wgoZghiQP/F4ZGmOLy2rGeC6LdX+Xm8sCZ3s4oMlCYh/W+f9WGTi6M/S2C2?=
 =?us-ascii?Q?vNEvThohDm1wQ1L4yft8EBTrKIMwJcznqJtiNryP1qKBit3W2P8eLfn/9neu?=
 =?us-ascii?Q?tValB9lYRtr/5aBtW2A8FNLbeNtKVqc61pPAbLlinqRQiedczv53n5KB0U7s?=
 =?us-ascii?Q?gsJiI1vi2Rd4M09zhG4F9ARmr1rzyv6r3gXJfOdO6nUZ90kuLfg9HR8S/oFE?=
 =?us-ascii?Q?LK/HJehjgt+MEJb+FGXjo7CLpDZTU9mgsy9aznW6HjWy5QAqMABJflvC+wIv?=
 =?us-ascii?Q?wphDCtOx5OJMuaOHSzaxTcLlDwmLMGNg0ihWV01NHxKSr+C4rSRot7n0rO7d?=
 =?us-ascii?Q?FkBkVnYndulEbX7SlsuzsX6/0WigMVePqvV4b+JK1Rf6Vveh4B6F84q5LBiZ?=
 =?us-ascii?Q?97S2ooMg1sDbRqscGFuD2UIVVPbLh0wcGH4XYz1wQX+8CeMgcOa4H3aaCwN7?=
 =?us-ascii?Q?vy/4ihf75dG1V8erKsbg6cyjNg/m0KOZQMFfocNaM8dv8hLWtYrgGzahLDyA?=
 =?us-ascii?Q?E0FeSTBoNI3Q6NGUsk/DDJEuhw/D3mdV+RPh3a4raVwnAeZ328Abi/F+nyWo?=
 =?us-ascii?Q?go0PnWEvOZuO7XPthjr524/Kw6zdYSzR/H+qE9wGdmguT+g5AYn/kn+3kHyx?=
 =?us-ascii?Q?qJegwVSgYojc7W9jun1YxFgRL+yLFi4WvkmStU8TUOL0spGwg7pMc/C4OHrd?=
 =?us-ascii?Q?JSaY8Q6WUsdAISKWzdIfOb8W/J8toDmN0g/jU8nrzVby6U98LWZRg3EkxR3b?=
 =?us-ascii?Q?FeVGvYJm72d57UsYq1r9WmNEGjOWee3/GSMO1WGFg5vjLnQClofAOsYLswsx?=
 =?us-ascii?Q?1ZpO9B2UAvXQGBS2c7goucHFA8JgVkKnQNhFsAqzQJtnws+gCkcAlsn8G5B1?=
 =?us-ascii?Q?1ty0r32YHelFRh0KUPKMEMcdiWIthrGcyjG1z7mFJn5f/fKI15cj0Nq6NnXZ?=
 =?us-ascii?Q?90tO+elebmVZyZx9hI0K47p+fKftlSOCjvzf68jJu5dJzviyfMLf3ScKu43x?=
 =?us-ascii?Q?r6B9Fhi4mCpMqyMpTQAg1CryeZUBTSlwMjEseu7Iv5y/8mnCG0G6fBWjCirh?=
 =?us-ascii?Q?2Uxr4S9wAo3iIVaePI5mz2Bx0QNees963iIAafH+ht8+qymNgSHZeVySv2mt?=
 =?us-ascii?Q?i9CPwHNk13EgRh8xbZI=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b43fa56c-5bbe-4d51-e342-08d9a83c2ed7
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 13:31:08.8543
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E8qaSVZ5FkxsD/tBAyfxAvudzWS6e6lbN6NLjRMlnmxKg+xCK1zdLWX418dCyoDA
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5111
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 15, 2021 at 05:21:26AM -0800, Christoph Hellwig wrote:
> On Mon, Nov 15, 2021 at 10:05:44AM +0800, Lu Baolu wrote:
> > pci_stub allows the admin to block driver binding on a device and make
> > it permanently shared with userspace. Since pci_stub does not do DMA,
> > it is safe.
> 
> If an IOMMU is setup and dma-iommu or friends are not used nothing is
> unsafe anyway, it just is that IOMMU won't work..
> 
> > However the admin must understand that using pci_stub allows
> > userspace to attack whatever device it was bound to.
> 
> I don't understand this sentence at all.

If userspace has control of device A and can cause A to issue DMA to
arbitary DMA addresses then there are certain PCI topologies where A
can now issue peer to peer DMA and manipulate the MMMIO registers in
device B.

A kernel driver on device B is thus subjected to concurrent
manipulation of the device registers from userspace.

So, a 'safe' kernel driver is one that can tolerate this, and an
'unsafe' driver is one where userspace can break kernel integrity.

The second issue is DMA - because there is only one iommu_domain
underlying many devices if we give that iommu_domain to userspace it
means the kernel DMA API on other devices no longer works. 

So no kernel driver doing DMA can work at all, under any PCI topology,
if userspace owns the IO page table.

Jason