Subject: Re: [syzbot] WARNING in usbnet_start_xmit/usb_submit_urb
To:     syzbot <syzbot+63ee658b9a100ffadbe2@syzkaller.appspotmail.com>,
        davem@davemloft.net, kuba@kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, netdev@vger.kernel.org,
        oneukum@suse.com, syzkaller-bugs@googlegroups.com
References: <000000000000a56e9105d0cec021@google.com>
From:   Oliver Neukum <oneukum@suse.com>
Message-ID: <042900c4-7758-bb90-bac1-c01b12df49bc@suse.com>
Date:   Mon, 15 Nov 2021 15:31:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
In-Reply-To: <000000000000a56e9105d0cec021@google.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wnG8xXXgJWabLA52hY8o3uGEC9yWQE7sCAgch81d4uY7IW06QgzYYE7fTN9c?=
 =?us-ascii?Q?lSVqC975/0lxIZ/fjzpH46W/K6/iNuTAXn7XiWw8zZSWB0AcN04seY2WMnSH?=
 =?us-ascii?Q?wIxUuVkUxhn+j8naieBeBmuE6+AWu56XlHsKCG0KYFrPoRRbR+odYJuo/iwK?=
 =?us-ascii?Q?XpEstku0nVa8XFX/8zbfKNc/bU1WNK1nmLsd9ACAydFzdZkITBpTUpXzPf7C?=
 =?us-ascii?Q?Qvh2p0Y1hpxgseydCm8656+iqNlmQ5F3hL1+LmMlfCsXxL4AkfKeyhmRUFCp?=
 =?us-ascii?Q?u7O/VffGWQsLhpuhcU1X1JSRhzAf1CmERCizbc3YZ0/KHmiCxq0dTYtu7o+v?=
 =?us-ascii?Q?mp9D+eRjXNNKDVkg0oEsZQTHCEKL6be/Axph/Lg343PFzOUbYVj3xFWKTBoT?=
 =?us-ascii?Q?EMpKZ4brRXs8d6ZIraRdRVioZMOxQSSsa2TVSxhI+n2tYn7l3OiaW8XB515g?=
 =?us-ascii?Q?es9YFeQhoywZ56tyPpf+cuCQLGfHOi3BAI3cTyW9Pc4MMqOtah+eGQq9ipMa?=
 =?us-ascii?Q?3+JXWHf8fTUjVijdWlcqAJM1Cxo2X2elhQwjMO0uH4k0dAn2zBsCz/3B3lbP?=
 =?us-ascii?Q?M9lh8hF3mXbJxgQpgMV+2bzMZ5HMgVQI6presLavwVQp6mRBTdBkqDcZTUQl?=
 =?us-ascii?Q?7bkaS4u2TlCLSviQv4OnoYfA2n5RaEJy6LTUbi4HnqEfd57kGOHPPMcZ8iCN?=
 =?us-ascii?Q?iBcwSeY7a3yH8fAwxwR6UTlDGMj67d30LnEo2BDKydEpPhAMGul2TOGHv6Ut?=
 =?us-ascii?Q?M61em6ikRBo3aG8iLfNBXkmiKNm8lXKGw0tds7Mx2te1+zShBUJ1nMqdcXdE?=
 =?us-ascii?Q?fAmOErCmU/bst2p52S1bzwILzSClF5AOArHhJhwNwBAYk93oax0WSJH5vwCw?=
 =?us-ascii?Q?cU44r8rmBl7b36kXum4QkxVHmmt84i2SntGVhpuE8rZUFirspbtjC/ZVffQk?=
 =?us-ascii?Q?mB417v0/nP7nz4slPeCLdDDwPUlBU+8ToQtXMDEcEbpdow6B/RzsavUbgPTR?=
 =?us-ascii?Q?zXtF+6eRsWdhN1R4NF7DsluYbf2lFAFhcBQTNooI7FpV+Y5gqHofpkgJFI4w?=
 =?us-ascii?Q?3v34ouecdQQQ5Gwk+yUTTstduRHBi/RqYMm7qIiXUmK2Wun2g0n6hWJaJjlK?=
 =?us-ascii?Q?ti4jskbauMit71iRQPFE//nulV1tGHEbacrCPleCssxR9haIxIjakqBu4vbP?=
 =?us-ascii?Q?pOPUEmHw1iXmtsPmIj7e9y2XMW+9Pd5Wt9ZbY5cw/BNydn0bWmOM1BcAZzfu?=
 =?us-ascii?Q?FLV82iR3bsarTs73tHZTrFFAK13FkGLAsBVGAiuebKbhmYR5ubDUBFReXE11?=
 =?us-ascii?Q?2ARTljOQaQRQI4BEtujMIYBNYOm0ljlEZhq8+L6slSj8OGstFx8yr98/PTr9?=
 =?us-ascii?Q?9Q+SEivDO4mloyAPFIQCLVszM5zJmf9juX+LxP2nwREXKvDv5lDYwJYKsoHF?=
 =?us-ascii?Q?v1erLmSaU5rRctpIKNMzCmu/t/AohVOwInQqj5gRVuPyNP/+niZiW56m7hGJ?=
 =?us-ascii?Q?SbvfBaw96WrZnMYLo0U9HV0QqQ5EXT1PCyocp6Liar4LoZcJq5Pw64cJd72K?=
 =?us-ascii?Q?6tBsRdK5AlzCl5dx3uyXcqRdMBAXvRJMwljCyo17nt0DYmT/pwTITWTGTLIX?=
 =?us-ascii?Q?ZkhJ6D2MNmaYVjkknHkQ5tPkoAuriCKfCtsSrwtZw4tMfs01i+zjJGivqrkO?=
 =?us-ascii?Q?3brQZ0EInilDtoZA4JJ2pU5Yqxs=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b891262-41cc-441a-ad16-08d9a8448f4a
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5050.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 14:31:06.6683
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hBe5lesLSI1fCEAMeHTOQW4NB140FhDx611WW3MA56kyG9+fSSkRx/hUN4cmn4erLxQ1kZAOb/R+i8/Pd/3IgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8284
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 15.11.21 08:28, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:    048ff8629e11 Merge tag 'usb-5.16-rc1' of git://git.kernel=
...
> git tree:       https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/us=
b.git usb-testing
> console output: https://syzkaller.appspot.com/x/log.txt?x=3D1480ade1b0000=
0
> kernel config:  https://syzkaller.appspot.com/x/.config?x=3Dd6b387bc5d3e5=
0f3
> dashboard link: https://syzkaller.appspot.com/bug?extid=3D63ee658b9a100ff=
adbe2
> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binuti=
ls for Debian) 2.35.2
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=3D1313cb7cb00=
000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=3D16a2f676b0000=
0
>
> IMPORTANT: if you fix the issue, please add the following tag to the comm=
it:
> Reported-by: syzbot+63ee658b9a100ffadbe2@syzkaller.appspotmail.com
>
> ------------[ cut here ]------------
> usb 5-1: BOGUS urb xfer, pipe 3 !=3D type 1
> WARNING: CPU: 0 PID: 1291 at drivers/usb/core/urb.c:502 usb_submit_urb+0x=
ed2/0x18a0 drivers/usb/core/urb.c:502

Hi,

here I understand what is happening, but not why it can happen. Usbnet
checks the endpoint type.

May I request an addition to syzbot? Could you include the output of
"lsusb -v" at the time
of the error condition for USB bugs?

=C2=A0=C2=A0=C2=A0 Regards
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 Oliver