Date:   Mon, 15 Nov 2021 16:38:35 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Marco Elver <elver@google.com>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        Alexander Potapenko <glider@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Petr Mladek <pmladek@suse.com>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Wei Liu <wei.liu@kernel.org>, Mike Rapoport <rppt@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        John Ogness <john.ogness@linutronix.de>,
        linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
        Alexander Popov <alex.popov@linux.com>
Subject: Re: [PATCH] panic: use error_report_end tracepoint on warnings
Message-ID: <YZJw69RdPES7gHBM@smile.fi.intel.com>
References: <20211115085630.1756817-1-elver@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211115085630.1756817-1-elver@google.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Nov 15, 2021 at 09:56:30AM +0100, Marco Elver wrote:
> Introduce the error detector "warning" to the error_report event and use
> the error_report_end tracepoint at the end of a warning report.
> 
> This allows in-kernel tests but also userspace to more easily determine
> if a warning occurred without polling kernel logs.

...

>  enum error_detector {
>  	ERROR_DETECTOR_KFENCE,
> -	ERROR_DETECTOR_KASAN
> +	ERROR_DETECTOR_KASAN,
> +	ERROR_DETECTOR_WARN

...which exactly shows my point (given many times somewhere else) why comma
is good to have when we are not sure the item is a terminator one in the enum
or array of elements.

>  };

-- 
With Best Regards,
Andy Shevchenko