Subject: Re: [PATCH v2 0/3] Add NVIDIA Tegra114 support to video decoder
 driver
To:     Nicolas Dufresne <nicolas@ndufresne.ca>,
        Dmitry Osipenko <digetx@gmail.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Anton Bambura <jenneron@protonmail.com>
Cc:     linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211114224732.11550-1-digetx@gmail.com>
 <1411d7a3913677fee58e103f7610e122686e87bf.camel@ndufresne.ca>
From:   Hans Verkuil <hverkuil@xs4all.nl>
Message-ID: <55f445d8-8207-35a3-6c6f-dcb9ea70a90f@xs4all.nl>
Date:   Mon, 15 Nov 2021 15:49:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <1411d7a3913677fee58e103f7610e122686e87bf.camel@ndufresne.ca>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 15/11/2021 15:43, Nicolas Dufresne wrote:
> Hi Dmitry,
> 
> Le lundi 15 novembre 2021 à 01:47 +0300, Dmitry Osipenko a écrit :
>> Video decoder of Tegra114/124 SoCs uses additional memory buffer required
>> for decoding of protected content. We won't support that content, but it
>> is impossible to disable access to the buffer, hence a stub buffer needs
>> to be provided. This series enables decoder driver only for Tegra114
>> because Tegra124 support requires more non-trivial changes on both kernel
>> and userspace sides.
> 
> I believe the stateless API is quite in place now, but I only see maintenance on
> this staging driver. I don't believe it really make sense to keep maintaining a
> staging driver without any step forward de-staging it. I believe it gives the
> wrong message on the Kernel staging purpose.
> 
> I'm not criticizing your effort, I believe you are doing nice work for you
> community, but would prefer to see this driver be ported to the official kernel
> APIs rather then being maintain as staging till the end of time.

I agree with Nicolas here. This driver only support H264 and the stateless API
for that is now in mainline. So there is no reason not to convert to the
stateless codec API and move this driver to mainline.

It would be really nice to see that happen.

Without any progress on that I am inclined to remove this driver some time
next year.

Regards,

	Hans

> 
> regards,
> Nicolas
> 
>>
>> Changelog:
>>
>> v2: - Changed tegra_vde_alloc_bo() to return errno and fix unassigned
>>       error code in tegra_vde_probe().
>>
>> Dmitry Osipenko (1):
>>   media: staging: tegra-vde: Reorder misc device registration
>>
>> Thierry Reding (2):
>>   media: staging: tegra-vde: Support reference picture marking
>>   media: staging: tegra-vde: Properly mark invalid entries
>>
>>  drivers/staging/media/tegra-vde/vde.c | 147 +++++++++++++++++++++++---
>>  drivers/staging/media/tegra-vde/vde.h |  18 ++++
>>  2 files changed, 152 insertions(+), 13 deletions(-)
>>
>