Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932091AbXAIN5f (ORCPT ); Tue, 9 Jan 2007 08:57:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932092AbXAIN5f (ORCPT ); Tue, 9 Jan 2007 08:57:35 -0500 Received: from e1.ny.us.ibm.com ([32.97.182.141]:46661 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932091AbXAIN5e (ORCPT ); Tue, 9 Jan 2007 08:57:34 -0500 Subject: Re: JFS: possible recursive locking detected From: Dave Kleikamp To: Srinivasa Ds Cc: Tomasz Kvarsin , linux-kernel@vger.kernel.org, jfs-discussion@lists.sourceforge.net, Andrew Morton , Linus Torvalds In-Reply-To: <45A3613F.1050604@in.ibm.com> References: <5157576d0701082333h276b99f3l7a785f6e2f250c27@mail.gmail.com> <45A3613F.1050604@in.ibm.com> Content-Type: text/plain Date: Tue, 09 Jan 2007 13:56:14 +0000 Message-Id: <1168350974.13500.5.camel@kleikamp.austin.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.8.2.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1594 Lines: 51 On Tue, 2007-01-09 at 15:02 +0530, Srinivasa Ds wrote: > Tomasz Kvarsin wrote: > > This I got during boot with 2.6.20-rc4: > > ============================================= > > [ INFO: possible recursive locking detected ] ... > So below patch should fix this problem,please test this. Let me know > your comments on this. I'm sure there are several other places in the jfs code that need the same treatment. I've put this off too long already. I'll get a comprehensive lock annotation patch out today, starting with this one. > > Signed-off-by: Srinivasa DS Thanks, Shaggy > > > plain text document attachment (jfs.fix) > namei.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: linux-2.6.20-rc4/fs/jfs/namei.c > =================================================================== > --- linux-2.6.20-rc4.orig/fs/jfs/namei.c > +++ linux-2.6.20-rc4/fs/jfs/namei.c > @@ -104,8 +104,8 @@ static int jfs_create(struct inode *dip, > > tid = txBegin(dip->i_sb, 0); > > - mutex_lock(&JFS_IP(dip)->commit_mutex); > - mutex_lock(&JFS_IP(ip)->commit_mutex); > + mutex_lock_nested(&JFS_IP(dip)->commit_mutex, I_MUTEX_PARENT); > + mutex_lock_nested(&JFS_IP(ip)->commit_mutex, I_MUTEX_CHILD); > > rc = jfs_init_acl(tid, ip, dip); > if (rc) -- David Kleikamp IBM Linux Technology Center - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/