Subject: Re: [PATCH] drm/amd/amdgpu: fix potential memleak
To:     Bernard Zhao <bernard@vivo.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Hawking Zhang <Hawking.Zhang@amd.com>,
        John Clements <john.clements@amd.com>,
        Jonathan Kim <jonathan.kim@amd.com>,
        Kevin Wang <kevin1.wang@amd.com>,
        Tian Tao <tiantao6@hisilicon.com>,
        Evan Quan <evan.quan@amd.com>, shaoyunl <shaoyun.liu@amd.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20211115025901.2598-1-bernard@vivo.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
Message-ID: <50ed4525-dbe6-1eac-5b83-4233a18a6176@amd.com>
Date:   Mon, 15 Nov 2021 10:56:28 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20211115025901.2598-1-bernard@vivo.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2o4R1FYS3A0SzFXVUlVVE0yN3dUTi9WR0FpU2dHWml1aEJVYng4U2s3QWFK?=
 =?utf-8?B?eFFUVlM3UlVycTNoa0lIV1o1V2szemJVSXRJWnprZGFmU1ZEamlObHhqN0NL?=
 =?utf-8?B?dHJVV0ZyWFdCOTdvU0t4Vm5uTmM5NC9lYUMyb0xJN2FpVSs0VmpLMm5iR01T?=
 =?utf-8?B?TDNycWEwbHlmVVArc0FwQ0U2UW95ZzMyL1l3bHcyQnI4SE9tekpnOVR5cG1J?=
 =?utf-8?B?R0pMSWxlbmg1dGdSS01HUk81elVBc0JVbVVvcDE5NFFIdzdaUXdza3RoTStF?=
 =?utf-8?B?clZrcEZ2dEYzNWFlcmV1VFpHZUlqNDE5T1VVWjU1QlV6dk5jaEFMR0NyelQz?=
 =?utf-8?B?ZGR1Yzh0anJTSk5ET1FPbnJVS2x3QjNDalU5R2luRU5PSFZtUG1KdkFQelRS?=
 =?utf-8?B?bGNyekl6alVTbDJNTWR0N1RaSG52Vy9GM1RuY2VvSnRQT1hXTjhxTnlxSGdi?=
 =?utf-8?B?N29xWE01djNiRllOa0V5M3JMTElGWlkyY2Mwdzd4M3B4TFNvemp2Qk9RWGZu?=
 =?utf-8?B?M3dBakdHdk9Rd1JxS3FockFodjZVeWY1T1JDd3hPdzkyYWZwUTVsNDVscjBx?=
 =?utf-8?B?ZHk5NjhjSGhxaVNHaFU5b1E5VVU5Mit2V21OWlVOMlloYnJvMEM4U093SUU2?=
 =?utf-8?B?bGNreGgxWTFQS3Y2R3BTSnhhcFh5Rkp4TFZPODhIOUFqTTZMemZrMWptUUlT?=
 =?utf-8?B?UnQyUGJSdFJkMnZVczFaTUJ5Ly9qUStPeXZUMzc3eW5Pc2ZZMCtJdGtDSG1E?=
 =?utf-8?B?SXJybUZsVWNHdmtOU2xKdWxWSlRCVWpZQWRHQWZSUHV3UjJLTlJhTXRQc1Bx?=
 =?utf-8?B?OE9YUEZFSFhIYlh1alZSdXhId0U3aHpRa0t3aEQrTVM2dXZYK3BoclMyYnlL?=
 =?utf-8?B?MFZkL09yZmFlemdXS255R3R1MVBlaWg1dTltWlJoQUFUbjFaakl1WUtWbm1m?=
 =?utf-8?B?TjQwazNKQ2YzSzZqQ1BubUNZcHE2azVxNEsySlJ3TktYZk4xbjI2Rjh2MHVm?=
 =?utf-8?B?bzJJQXc1Z0huQ2hoWmJuL2VFYVQ5ZFhVKzdheTd2eTZiblA2c2w4VTB6SWsv?=
 =?utf-8?B?SmR5UmR0bCs0VW8rbDNQcS9yOEU5bEtZN0x1Nmg5bnF5UEduek55NStHSXVq?=
 =?utf-8?B?MXRnbnBjOXJQc0dENDRZTzBvc3R3d2hWK0dhWUdYOVlkR3hxWjU3MDNQNlli?=
 =?utf-8?B?Z0J3Zm1tbjVIZWE4NEpNdWVRWENWM1lqZWZUVDJDYXZKZ3NlVDZCWTFZV1Zt?=
 =?utf-8?B?TDA1R3kvbmlkZzZINkE1bjQwZm5vZnJhK1JCbTdFRlJGS0tOSVR3eUlBbjZ3?=
 =?utf-8?B?TjFsTW1uZ2c1Q0xtY0ZucjVrTGxLOU5zbVNmbmlPeGcwOGVsMnhnUXlxVjRm?=
 =?utf-8?B?ckZiUGFRaklzYXk0RUZTRktBU0hGbEdkSlhvZnZkNmpxUTdVZVhsS1Jid3RB?=
 =?utf-8?B?c0xmNTQ3ZXRDdWF1K0ZQMHdCT1p1UjZEQ291UlZvekcyWWN3TDAwRmVEcHk1?=
 =?utf-8?B?enFsRWRxdGhHbGlyOVFEVTdNSU5rNG5BN0J6NitaYVZXMkIzRHYwU0hCYUY3?=
 =?utf-8?B?elNIbDQyaWVOMzc2VkFraXRNZzJwekgvZ21UUkVMQnNQbFdHNDBXcWdBcFlV?=
 =?utf-8?B?NUpVb1BGZWxCRzdnQXVsV2txckhCWnZrWXlqblUxVG1lMWEvWkUrSEpXYktL?=
 =?utf-8?B?NUtYaElYN3lRcjJUb1R2T2lnUGFCTUJqNjd6dnVUVWtYVjlsTWhXQklFR1k3?=
 =?utf-8?B?Nk1EZWVMaTl1MlQ2YnlPMnc2bVhoMkRSa0pNd1U4Z0hwTFlrbHBiYXVndVhL?=
 =?utf-8?B?SjRya1pHUmlGZnkyV1NWWkphUWJQMDhpcnBNbUhnd3ZVdWsvN1cwbC9Oc2dC?=
 =?utf-8?B?YXk2WmFYVGpSczUzdWNDUHhXT09rRWtLQTgwbkRGcytHMWV2eVVrWmRHRzVL?=
 =?utf-8?B?S21obHpUVHlFa0xmeHMrN003K1JhM0htaEVPdVZMeG05SlJ5RHhhdzJra0Uv?=
 =?utf-8?B?RDZsaXNVK0EvVmR6MjQ0ZXc1bUFyclJrL2FJdkJ6TXJrYWdNVXJRNUZtdnhI?=
 =?utf-8?B?YjhpTHdNdC83ZUZ1Wm5ad2ZKKzJMZW85MzNENjhYNEt2S0cyZzBlN2crandU?=
 =?utf-8?B?c0VDUGVZZGptK0JFc1lseDBnTCtoTk9oZ1ZaOW9uQ2NNS1RXb0Fkd1UyQUMy?=
 =?utf-8?Q?oJEnN+xWT2APba9QqB6IOdY=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3a6bd07-f129-4ee2-bde4-08d9a8507d47
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5112.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 15:56:30.8303
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: o3bqrN+Ncj2ka72raF3UFhcvSQsjCmbmkaC9WemhCQ/0fSfTLNJ+KqiFFWz+J+UIoO55VDuKg/yA+/59TBUVuA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5238
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 2021-11-14 um 9:58 p.m. schrieb Bernard Zhao:
> In function amdgpu_get_xgmi_hive, when kobject_init_and_add failed
> There is a potential memleak if not call kobject_put.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>

Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>


> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> index 0fad2bf854ae..567df2db23ac 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> @@ -386,6 +386,7 @@ struct amdgpu_hive_info *amdgpu_get_xgmi_hive(struct amdgpu_device *adev)
>  			"%s", "xgmi_hive_info");
>  	if (ret) {
>  		dev_err(adev->dev, "XGMI: failed initializing kobject for xgmi hive\n");
> +		kobject_put(&hive->kobj);
>  		kfree(hive);
>  		hive = NULL;
>  		goto pro_end;