Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34AC1C43219 for ; Mon, 15 Nov 2021 17:21:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 29494632B6 for ; Mon, 15 Nov 2021 17:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237701AbhKORXz (ORCPT ); Mon, 15 Nov 2021 12:23:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:51468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236809AbhKORNN (ORCPT ); Mon, 15 Nov 2021 12:13:13 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8F1A86322A; Mon, 15 Nov 2021 17:10:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1636996216; bh=Wlq4wMtoqszeIGIY8PNNR3ew9tDmFX5MhrvpypRlMoU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WG/AIvx+YWAC32Bnf5qJ8kAr6+484nyYlRXzOQl85Psaq8qFrZbliCKLUzrJJKgDc GN9WEOQU2sk8KHhfbwQ345a7w9pdzcs93uYo8KKKuONX7Z4ELzjlOwwn8X5XCgcW6T A3IaouaU89TMd+BrvSjJlj7z+d6C1XnuZwaRekkc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dongli Zhang , "David S. Miller" , Sasha Levin Subject: [PATCH 5.4 057/355] vmxnet3: do not stop tx queues after netif_device_detach() Date: Mon, 15 Nov 2021 17:59:41 +0100 Message-Id: <20211115165315.658307598@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211115165313.549179499@linuxfoundation.org> References: <20211115165313.549179499@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dongli Zhang [ Upstream commit 9159f102402a64ac85e676b75cc1f9c62c5b4b73 ] The netif_device_detach() conditionally stops all tx queues if the queues are running. There is no need to call netif_tx_stop_all_queues() again. Signed-off-by: Dongli Zhang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/vmxnet3/vmxnet3_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index a06e6ab453f50..cf090f88dac03 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -3634,7 +3634,6 @@ vmxnet3_suspend(struct device *device) vmxnet3_free_intr_resources(adapter); netif_device_detach(netdev); - netif_tx_stop_all_queues(netdev); /* Create wake-up filters. */ pmConf = adapter->pm_conf; -- 2.33.0