Subject: Re: [PATCH] reset: tegra-bpmp: Revert Handle errors in BPMP response
To:     Mikko Perttunen <cyndis@kapsi.fi>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Thierry Reding <thierry.reding@gmail.com>
Cc:     Mikko Perttunen <mperttunen@nvidia.com>,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211112112712.21587-1-jonathanh@nvidia.com>
 <417a93fd-7581-1d33-1522-31f05ca253b9@kapsi.fi>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <984f6fd2-8d06-11b2-4e8f-b9db924a6519@nvidia.com>
Date:   Mon, 15 Nov 2021 18:09:48 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <417a93fd-7581-1d33-1522-31f05ca253b9@kapsi.fi>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjlMMmh6Y2JYTDlCTUFNSWw3TXo4bDNmVk5sNHdBMUwwNFhLcjVKN3hyVk9a?=
 =?utf-8?B?OVBOZFJwYWcvc3J2MlVHb2NUQ3FPM3FBLzB0WTk5L3ozeTI0WUlXeVRUd2ZI?=
 =?utf-8?B?aHZYTzB1WGJhTUVaaW9PWFNkUU5uUmY2Z2NHcGVJTDN0R1pyK3d0TWs5dStF?=
 =?utf-8?B?UmlZalAvMXhkZksyUERMaEt5bndqaDQ5OStIbnRVMlRyR0pKTHlUbWd5VWxq?=
 =?utf-8?B?VVM4SnFkOGJEQ2V3NUM0VVVHUWRINldpTStjQVBTUm51bnVRSW9SRWVGRHox?=
 =?utf-8?B?TzlaNEFBcGVNREp3M0k3WUFiOFdFYUdwaU1JclNleW1tNlU2dG5zOFFmeUp1?=
 =?utf-8?B?R0FmaWx4SVJNNlJGbnR1TnpLZE8zQzh0ZGxONDdiVW9NTnBGVE9ETUIyMytk?=
 =?utf-8?B?TzVzaHRrZTkvK3hhbWkrUHQ4SnpHOFI2NXdvalZxbDNyS3BMd0VjV2hCeE5W?=
 =?utf-8?B?ckxoVzd6TkJQaDlDbkEwcHc1VmRJU1B3RXc0WmJpc2U2OGs4UVp2bVphbzVE?=
 =?utf-8?B?R2lNNmtVelVtaDVvb1NPRnRUdGJRRDNoY3Z4elZkR3o4VnFGaURFZCs5U1ZE?=
 =?utf-8?B?dUhYTTNpUXhqU1lWSmRJeGZFL0hPck93TERHSjYvaytrYzREUEN2dTJSNXZW?=
 =?utf-8?B?Sk1sUnVhNmFaQ1JVRWl3cUVZaVByUGhwU3JlZjJRcW1DZUE5SFhLZzFheW01?=
 =?utf-8?B?WGpiR2pDY3lVL2tMM1FhY2VrQUI0U2d0ck5mblNYTmY1VWVBeHU5Q0UvWkox?=
 =?utf-8?B?dFoxYXRFL1NYUkwwZnNRTFpMb0FsS1RqV21mVjEzdkN5M0R0QWp3clJUa0Ur?=
 =?utf-8?B?RnVFZ3RGSDZ1SXJPcTcyYjRDcDlDWVdMbDFaeWtwMUtkWlByNkRGdWhJeTA0?=
 =?utf-8?B?Vm15Q3VMdDBReHdNbVQ4b3RxRVNCZHp0eTVkUFczYkRKRVFrdWppQmhhR0kv?=
 =?utf-8?B?RnQ4K2puVmhmbFBrSjZTaHI3VCs2dWNTeGlaWjNacytXWkZ1MmRUTTQ0dEtJ?=
 =?utf-8?B?YkN4OGVIRWNlOVBvS2lwWHF5aVl2Q0o5emhtN3dTMU02clBRVUR2YjhQWU15?=
 =?utf-8?B?UDM2cDArWGZJRk03Y2EzS1l2S3gxM3h6QWpRM2pvNklDRW9JdWF6TzlaNXJt?=
 =?utf-8?B?SUN1TTlvODVSY0ZCKzNqWWxDekdOZ0x4S0x3dnZUVjFLUSsvdFJjY09rK3JX?=
 =?utf-8?B?cWloRTJyWnBrRndKM0ptL2lDeXZiRmxya3piNk8yWXdCWEV2N3dyZ1hhSisz?=
 =?utf-8?B?d1Zvb2gzZ01uajlOK2ttb2FRaTFHMU9PQ1FoSmUwNDNsT0hrSzYwUTc5cjJ0?=
 =?utf-8?B?eXlFaDhURERVTW1NeXpLTml2c3RJM1BmYkNJRkF3ZnY2VXRPQ1poODZXdWRP?=
 =?utf-8?B?SXdVdWJDY2VBTi9zTFNPZjMwN09UU2h0Z09ob1ZUbzdoRjRQaXkwSUxWYnA4?=
 =?utf-8?B?a2YyOE5oL3BvWE9RbS9VNVpQV2IwREVqMlZkOVU5YjBieU52MCsvRmQ4NC8v?=
 =?utf-8?B?ZTdSMmZQQTVlTko1SXVaV2Y0bVNWZmwzdmduNjBrMDhWL3hGYTNzZjdwaVFW?=
 =?utf-8?B?MjRXRXhKelR3NjdoZkVmZ2ViQ1FMVXRKZmlYTE80WmQ0cGFIMUh1RUpYMzZu?=
 =?utf-8?B?UVF6UzBpNzkzQ2F2RVhXWjlmRThJZTV6dUNPd296dDFCQzVHeUpvajBhbTZ1?=
 =?utf-8?B?ckJxalBHSjgyaENJNmIxM0JyWDdNZTM0NjJ5a1NENDR4Q2NaMFVmWit3RjBr?=
 =?utf-8?B?Y2hKK3ZmbUd2VTd5QlVLR2hmbDlybnFNS0pYbVgrWElrNitjaGVBMDMrNFVs?=
 =?utf-8?B?UmsxempYQ0M0ZVlqRTJHY0x0cUdUVmtQSnRpNG1pZ0FYenpBN08vazhpQ0Y3?=
 =?utf-8?B?SnRMYi95amZVL2VHc1hsclZENUNPTThvYjJqWUhDM3liVmN4dXZLZ2g5Wm9L?=
 =?utf-8?B?NVpXaUNhZFNzMnlMRGs5blN4TEdYWFBlckhRQ093RHFWcjhJK29walcvRlli?=
 =?utf-8?B?NENDMnlYZ3orQVprU0hFU2Vwc1IyZjJMWjRWYTdXZk5SeFV1UUFrMURmMG9Q?=
 =?utf-8?B?dFJwWldMOE4wc2JDSnRMNnpiL0VRTHdnUUNjbEFkWUx0OEZDMUswRXp5aGh5?=
 =?utf-8?B?NEJlTityc3pWM3I0UHgwR2V3bjVFNW8xcHBaTXJlNGlQV2o3SDVuMWpzblQ3?=
 =?utf-8?B?UXpla1Q0c3BXbHpISHlkODBnWDd5bnJyaDNERkxQMU1iQ2ZIeWVSck03bFR4?=
 =?utf-8?Q?Yy93xvEjT/kFP0QNbdiEKSZdtpncQYjG8MxWgYL8yc=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ede1eb2d-319f-465a-25d4-08d9a8631f12
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2021 18:09:52.7760
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ncli17RrqB+buxtLAf/rkkxylGUSisIhQjeXYntS6m8Xcj2WlGFnNhSS4lew1Jd4qA5Ei0f4Ro+d6w5HgWeZ3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5200
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 15/11/2021 17:21, Mikko Perttunen wrote:
> On 11/12/21 1:27 PM, Jon Hunter wrote:
>> Commit c045ceb5a145 ("reset: tegra-bpmp: Handle errors in BPMP
>> response") fixed an issue in the Tegra BPMP error handling but has
>> exposed an issue in the Tegra194 HDA driver and now resetting the
>> Tegra194 HDA controller is failing. For now revert the commit
>> c045ceb5a145 ("reset: tegra-bpmp: Handle errors in BPMP response")
>> while a fix for the Tegra HDA driver is created.
>>
>> Fixes: c045ceb5a145 ("reset: tegra-bpmp: Handle errors in BPMP response")
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>>   drivers/reset/tegra/reset-bpmp.c | 9 +--------
>>   1 file changed, 1 insertion(+), 8 deletions(-)
>>
>> diff --git a/drivers/reset/tegra/reset-bpmp.c 
>> b/drivers/reset/tegra/reset-bpmp.c
>> index 4c5bba52b105..24d3395964cc 100644
>> --- a/drivers/reset/tegra/reset-bpmp.c
>> +++ b/drivers/reset/tegra/reset-bpmp.c
>> @@ -20,7 +20,6 @@ static int tegra_bpmp_reset_common(struct 
>> reset_controller_dev *rstc,
>>       struct tegra_bpmp *bpmp = to_tegra_bpmp(rstc);
>>       struct mrq_reset_request request;
>>       struct tegra_bpmp_message msg;
>> -    int err;
>>       memset(&request, 0, sizeof(request));
>>       request.cmd = command;
>> @@ -31,13 +30,7 @@ static int tegra_bpmp_reset_common(struct 
>> reset_controller_dev *rstc,
>>       msg.tx.data = &request;
>>       msg.tx.size = sizeof(request);
>> -    err = tegra_bpmp_transfer(bpmp, &msg);
>> -    if (err)
>> -        return err;
>> -    if (msg.rx.ret)
>> -        return -EINVAL;
>> -
>> -    return 0;
>> +    return tegra_bpmp_transfer(bpmp, &msg);
>>   }
>>   static int tegra_bpmp_reset_module(struct reset_controller_dev *rstc,
>>
> 
> Is there some reason the subject and commit message does not follow 
> normal revert convention (as done by 'git revert')?


Some maintainers prefer that the patch is not titled "Revert ..." and 
want the patch subject to follow the normal sub-system prefix. If you 
search through the patches for 'revert' in the subject you will see a 
mixture. I prefer this approach.

Jon

-- 
nvpublic