Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932340AbXAISfg (ORCPT ); Tue, 9 Jan 2007 13:35:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932341AbXAISfg (ORCPT ); Tue, 9 Jan 2007 13:35:36 -0500 Received: from smtp.osdl.org ([65.172.181.24]:59962 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932332AbXAISff (ORCPT ); Tue, 9 Jan 2007 13:35:35 -0500 Date: Tue, 9 Jan 2007 10:35:30 -0800 From: Stephen Hemminger To: Dmitriy Monakhov Cc: linux-kernel@vger.kernel.org, Andrew Morton , devel@openvz.org, linux-pci@atrey.karlin.mff.cuni.cz, netdev@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 1/5] fixing errors handling during pci_driver resume stage [net] Message-ID: <20070109103530.2f10f823@freekitty> In-Reply-To: <87vejgmv51.fsf@sw.ru> References: <87vejgmv51.fsf@sw.ru> Organization: OSDL X-Mailer: Sylpheed-Claws 2.5.0-rc3 (GTK+ 2.10.6; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 659 Lines: 18 On Tue, 09 Jan 2007 12:01:14 +0300 Dmitriy Monakhov wrote: > network pci drivers have to return correct error code during resume stage in > case of errors. > Signed-off-by: Dmitriy Monakhov > ----- Please don't introduce one dev_err() call into a device driver if all the other error printout's use a different interface. -- Stephen Hemminger - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/