Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932353AbXAIShN (ORCPT ); Tue, 9 Jan 2007 13:37:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932348AbXAIShN (ORCPT ); Tue, 9 Jan 2007 13:37:13 -0500 Received: from smtp.osdl.org ([65.172.181.24]:60086 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932351AbXAIShK (ORCPT ); Tue, 9 Jan 2007 13:37:10 -0500 Date: Tue, 9 Jan 2007 10:33:09 -0800 From: Stephen Hemminger To: Auke Kok Cc: Andrew Morton , Jeff Garzik , NetDev , Linux Kernel Mailing List , Arjan van de Ven Subject: Re: [PATCH -MM] e1000: rewrite hardware initialization code Message-ID: <20070109103309.0b872a53@freekitty> In-Reply-To: <45A3D29D.1000202@intel.com> References: <45A3D29D.1000202@intel.com> Organization: OSDL X-Mailer: Sylpheed-Claws 2.5.0-rc3 (GTK+ 2.10.6; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2548 Lines: 56 On Tue, 09 Jan 2007 09:36:29 -0800 Auke Kok wrote: > > Andrew, All, > > This patch contains a major rewrite to the e1000 driver that groups and separates e1000 > hardware by chipset family. It abstracts the hardware specific code into an API that > will allow us to continue to maintain the complex e1000 driver and add new hardware > support to it without touching code that affects older chipsets. Thats good. but: > drivers/net/e1000/Makefile | 19 > drivers/net/e1000/e1000.h | 95 > drivers/net/e1000/e1000_80003es2lan.c | 1330 +++++ > drivers/net/e1000/e1000_80003es2lan.h | 89 > drivers/net/e1000/e1000_82540.c | 586 ++ > drivers/net/e1000/e1000_82541.c | 1164 ++++ > drivers/net/e1000/e1000_82541.h | 86 > drivers/net/e1000/e1000_82542.c | 466 ++ > drivers/net/e1000/e1000_82543.c | 1397 +++++ > drivers/net/e1000/e1000_82543.h | 45 > drivers/net/e1000/e1000_82571.c | 1132 ++++ > drivers/net/e1000/e1000_82571.h | 42 > drivers/net/e1000/e1000_api.c | 1077 ++++ > drivers/net/e1000/e1000_api.h | 159 + > drivers/net/e1000/e1000_defines.h | 1289 +++++ > drivers/net/e1000/e1000_ethtool.c | 470 +- > drivers/net/e1000/e1000_hw.c | 9038 --------------------------------- > drivers/net/e1000/e1000_hw.h | 3859 ++------------ > drivers/net/e1000/e1000_ich8lan.c | 2353 +++++++++ > drivers/net/e1000/e1000_ich8lan.h | 108 > drivers/net/e1000/e1000_mac.c | 1921 +++++++ > drivers/net/e1000/e1000_mac.h | 84 > drivers/net/e1000/e1000_main.c | 1002 ++-- > drivers/net/e1000/e1000_manage.c | 387 + > drivers/net/e1000/e1000_manage.h | 83 > drivers/net/e1000/e1000_nvm.c | 860 +++ > drivers/net/e1000/e1000_nvm.h | 61 > drivers/net/e1000/e1000_osdep.h | 56 > drivers/net/e1000/e1000_param.c | 115 > drivers/net/e1000/e1000_phy.c | 1932 +++++++ > drivers/net/e1000/e1000_phy.h | 157 + > drivers/net/e1000/e1000_regs.h | 236 + > 32 files changed, 18538 insertions(+), 13160 deletions(-) Is lots of little files really progress? -- Stephen Hemminger - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/