From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@osdl.org>
Subject: Re: [2.6 patch] x86_64: re-add a newline to RESTORE_CONTEXT
Date: Wed, 10 Jan 2007 00:43:48 +0100
User-Agent: KMail/1.9.5
Cc: Adrian Bunk <bunk@stusta.de>, discuss@x86-64.org,
       linux-kernel@vger.kernel.org, "Steven M. Christey" <coley@mitre.org>
References: <20070109025516.GC25007@stusta.de> <200701092343.01112.ak@suse.de> <20070109145247.1ffc0cd3.akpm@osdl.org>
In-Reply-To: <20070109145247.1ffc0cd3.akpm@osdl.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200701100043.49092.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1064
Lines: 27


> 
> In other words we'll leave it in its present buggy form so that it will
> explode next time someone tries to use it for something new, rather than a)

It shouldn't be used for anything new. It's really a private macro
in the context switch code, nothing that any other code is supposed
to use.

> fixing that potential problem and b) fixing a real problem with a popular
> external GPLed product.

kgdb shouldn't need any patches to core kernel I had it some time ago running fine
just by hooking it into the die hooks (and minor changes to the serial layer,
with netpoll these shouldn't be even needed anymore) 

If the kgdb people need more changes they should submit them.

But I suspect if they change RESTORE_CONTEXT they're doing something wrong
anyways and they just need to fix their code properly.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/