Sender: Tejun Heo <htejun@gmail.com>
Date:   Mon, 15 Nov 2021 11:21:43 -1000
From:   Tejun Heo <tj@kernel.org>
To:     Wei Yang <richard.weiyang@gmail.com>
Cc:     lizefan.x@bytedance.com, hannes@cmpxchg.org,
        cgroups@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch v2] cgroup: pretty format /proc/cgroups
Message-ID: <YZLPZwo7IkgctGwD@slm.duckdns.org>
References: <20211115011253.20778-1-richard.weiyang@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211115011253.20778-1-richard.weiyang@gmail.com>
Precedence: bulk

On Mon, Nov 15, 2021 at 01:12:53AM +0000, Wei Yang wrote:
> Current /proc/cgroups looks like this:
> 
>  subsys_name    hierarchy       num_cgroups     enabled
> cpuset  3       1       1
> cpu     2       1       1
> cpuacct 2       1       1
> memory  4       71      1
> freezer 5       1       1
> 
> Let's align the title and value. After this patch, it looks like this.
> 
>  subsys_name    hierarchy       num_cgroups     enabled
>       cpuset            5                 1           1
>          cpu            3                 1           1
>      cpuacct            3                 1           1
>       memory            2                71           1
>      freezer            4                 1           1
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>

So, I know it's silly but the file is dumb \t formatted (ie. single \t
between fields) and am slightly worried that changing the format might break
some dumb userspace tooling. Given that the information isn't really needed
for cgroup2 anyway, it prolly is better to leave it as-is, I think.

Thanks.

-- 
tejun