Date:   Tue, 16 Nov 2021 06:15:28 +0900
From:   Stafford Horne <shorne@gmail.com>
To:     Johan Hovold <johan@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ilia Sergachev <silia@ethz.ch>,
        Karol Gugala <kgugala@antmicro.com>,
        Mateusz Holenko <mholenko@antmicro.com>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, Filip Kokosinski <fkokosinski@antmicro.com>
Subject: Re: [PATCH 1/3] serial: liteuart: fix compile testing
Message-ID: <YZLN8LXHl9FURgsU@antec>
References: <20211115133745.11445-1-johan@kernel.org>
 <20211115133745.11445-2-johan@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211115133745.11445-2-johan@kernel.org>
Precedence: bulk

On Mon, Nov 15, 2021 at 02:37:43PM +0100, Johan Hovold wrote:
> Allow the liteuart driver to be compile tested by fixing the broken
> Kconfig dependencies.
> 
> Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
> Cc: stable@vger.kernel.org	# 5.11
> Cc: Filip Kokosinski <fkokosinski@antmicro.com>
> Cc: Mateusz Holenko <mholenko@antmicro.com>
> Cc: Stafford Horne <shorne@gmail.com>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Reviewed-by: Stafford Horne <shorne@gmail.com>

> ---
>  drivers/tty/serial/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 6ff94cfcd9db..67de892e0947 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1531,9 +1531,9 @@ config SERIAL_MILBEAUT_USIO_CONSOLE
>  
>  config SERIAL_LITEUART
>  	tristate "LiteUART serial port support"
> +	depends on LITEX || COMPILE_TEST
>  	depends on HAS_IOMEM
> -	depends on OF || COMPILE_TEST
> -	depends on LITEX
> +	depends on OF
>  	select SERIAL_CORE
>  	help
>  	  This driver is for the FPGA-based LiteUART serial controller from LiteX
> -- 
> 2.32.0
>