MIME-Version: 1.0
References: <20211116091702.3e2c4550@canb.auug.org.au>
In-Reply-To: <20211116091702.3e2c4550@canb.auug.org.au>
From:   Steve French <smfrench@gmail.com>
Date:   Mon, 15 Nov 2021 16:35:51 -0600
Message-ID: <CAH2r5mu6qbpFc23DtDj_pAD1zF9foJ5bSocGQiOzEurZ4ULYFQ@mail.gmail.com>
Subject: Re: linux-next: build failure after merge of the cifs tree
To:     Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     CIFS <linux-cifs@vger.kernel.org>,
        chiminghao <chi.minghao@zte.com.cn>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

patch removed pending author fix

On Mon, Nov 15, 2021 at 4:17 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> In file included from fs/cifs/dns_resolve.c:18:
> fs/cifs/cifsglob.h: In function 'cifs_get_tlink':
> fs/cifs/cifsglob.h:1169:14: error: passing argument 1 of 'atomic_inc' from incompatible pointer type [-Werror=incompatible-pointer-types]
>  1169 |   atomic_inc(&tlink->tl_count);
>       |              ^~~~~~~~~~~~~~~~
>       |              |
>       |              refcount_t * {aka struct refcount_struct *}
> In file included from include/linux/atomic.h:82,
>                  from include/linux/cpumask.h:13,
>                  from include/linux/smp.h:13,
>                  from include/linux/lockdep.h:14,
>                  from include/linux/spinlock.h:62,
>                  from include/linux/mmzone.h:8,
>                  from include/linux/gfp.h:6,
>                  from include/linux/slab.h:15,
>                  from fs/cifs/dns_resolve.c:15:
> include/linux/atomic/atomic-instrumented.h:179:22: note: expected 'atomic_t *' but argument is of type 'refcount_t *' {aka 'struct refcount_struct *'}
>   179 | atomic_inc(atomic_t *v)
>       |            ~~~~~~~~~~^
>
> and lots more similar ...
>
> Caused by commit
>
>   ef242296e441 ("fs:cifs: convert from atomic_t to refcount_t on tlink->tl_count")
>
> Please write, review, test (repeat) and, only then, publish. :-(
>
> I have used the cifs tree from next-20211115 for today.
>
> --
> Cheers,
> Stephen Rothwell


-- 
Thanks,

Steve