Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964854AbXAJLLu (ORCPT ); Wed, 10 Jan 2007 06:11:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964851AbXAJLLs (ORCPT ); Wed, 10 Jan 2007 06:11:48 -0500 Received: from mailhub.sw.ru ([195.214.233.200]:15716 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964854AbXAJLLq (ORCPT ); Wed, 10 Jan 2007 06:11:46 -0500 To: Stephen Hemminger Cc: Dmitriy Monakhov , linux-kernel@vger.kernel.org, Andrew Morton , devel@openvz.org, linux-pci@atrey.karlin.mff.cuni.cz, netdev@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 1/5] fixing errors handling during pci_driver resume stage [net] References: <87vejgmv51.fsf@sw.ru> <20070109103530.2f10f823@freekitty> From: Dmitriy Monakhov Date: Wed, 10 Jan 2007 14:11:58 +0300 In-Reply-To: <20070109103530.2f10f823@freekitty> (Stephen Hemminger's message of "Tue, 9 Jan 2007 10:35:30 -0800") Message-ID: <878xgb5e69.fsf@sw.ru> User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 29 Stephen Hemminger writes: > On Tue, 09 Jan 2007 12:01:14 +0300 > Dmitriy Monakhov wrote: > >> network pci drivers have to return correct error code during resume stage in >> case of errors. >> Signed-off-by: Dmitriy Monakhov >> ----- > > Please don't introduce one dev_err() call into a device driver if all the other > error printout's use a different interface. Ok. It was wrong decision to fix all affected drivers in one patchset. Especially without respect to concrete driver specific. I'll try to rewrite it in more slowly but (i hope) more correct way > > -- > Stephen Hemminger > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/