From:   Bernard Zhao <bernard@vivo.com>
To:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?q?Christian=20K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Bernard Zhao <bernard@vivo.com>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drm/amd/display: cleanup the code a bit
Date:   Mon, 15 Nov 2021 17:34:35 -0800
Message-Id: <20211116013438.26517-1-bernard@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M1seUm3vgCIn3WXvX6rtdROGsRYglHCg1rq9wscj0+AEBxfOnp/tdXs+H3Mc?=
 =?us-ascii?Q?LqHL2RjkZm70Az6NsmGPUocKipsqL79UcnExjGceMazsV6tti8ELUlqqhveB?=
 =?us-ascii?Q?KwyB5vDH8Ysc9HtrEhZnHbsU15qi2Qj2jrbRAA9CWqu8bXE+sXCIftR25AQP?=
 =?us-ascii?Q?PrC4+YDHyhZ+eHcX83bqBl5afk8GYncke9UOaWKQ290bw1JLIXyyxv+l0Jl8?=
 =?us-ascii?Q?LiyAo8tZsEEBs++HHPq0CxRJrjjJpAi4hseVgiwAyUY7MLo+b1ZooXjYQXOI?=
 =?us-ascii?Q?mwoup9sFhI8926+lrw+YW+4fVgff4jgk8Qxf6Jwq0Yt4VIg6HYt/3o2yErSB?=
 =?us-ascii?Q?tD+kn0FXoxsogUBiZrnzy17spzqruUq+LGUvSA6H0iXVGkvpclYPGURm6Fa+?=
 =?us-ascii?Q?ThI7QfNTbQxux2m7VkfPqcmAub/ivrDJHxGyXgfFcp/qbCVuSGofK1sjUuOc?=
 =?us-ascii?Q?Yq0jycKW3lSV2jK0C6baH+3hogDydjk5BjPp2sJui2YtUviBCeUD0WlPrrhO?=
 =?us-ascii?Q?SyDKX2kI0PsJYEzenNHcVOFxDQIeEEfsYB3xZ2hrykjtwJdy2uGbVHhOnFUV?=
 =?us-ascii?Q?hIpPLgrsRUs+UA8WhUtNaJIlLogjydiEwzhWMA9dE2Rxi/KTzQ33eMIh4AI4?=
 =?us-ascii?Q?RuUnSHDqw+t63fmaXhgAl/Kw9UFpfgYMsFRTLuhxA1hhq9y7oJ1pOqaggKl9?=
 =?us-ascii?Q?hTVXg0DSKsZ01tOEUVNoF3Qnjh2w2rsylSnVnKWtLKvFTH/kd+YabgAwgx0g?=
 =?us-ascii?Q?9l/WDgQl+TDvcS++4v4R0H+tcKsz75k/CsIYTZoEFrlyclwVUF9pT4iRZhvw?=
 =?us-ascii?Q?NhF1QWDOds9COg5l9qlRv1pI02c8fbMqjlU6vJf8q0kVBq+cwGLAfCwSOsqB?=
 =?us-ascii?Q?1xJivcF2lprUH60aFR9K52HhiTuYk7NrehG3Lh5l4G1a4Z5QDLKbodOXC1mR?=
 =?us-ascii?Q?dhI0fqd9Jdxrid5cZMmody5SSrGFijT57qWOQY+aKXlp4jLGk6HUZFXt00f6?=
 =?us-ascii?Q?UbdDWM6kpL/7M5tLLjTDRQDNaWzxbYS1MV22QPl7xO8CdHMdNyt9ZokCkN7N?=
 =?us-ascii?Q?YhTUUdGAK+cJZos9GRpVDBAIE/BfBGUF6wm/mYM6b7YwSEpMZSVtUDp2SCJv?=
 =?us-ascii?Q?VzMgG513AgXHDotwyyS7QcWlM43ZEcAjxkiCYfBBCeODVg/7XHjmN05sXru6?=
 =?us-ascii?Q?tPN6RvyD2gB17FVvJCl0RQcevuA+vJwvROVKIbHC6x6rOWb3QewMxMYGiXTo?=
 =?us-ascii?Q?Ugorknn304eavuRsO3fvKDvGYeX7gv7KKMyLf+rYI9FwZ0O83CHegg5sRSWd?=
 =?us-ascii?Q?t/s3SQRM4xL/ulW68bL+Zu3JFpU6HWjSCtfk3lguRy22OaUDKNP+9cZeDtJH?=
 =?us-ascii?Q?COEEfqHT+IyIwbSF3j8bq+nkOeXo+HwVCNNHLH1H1R+ZeHH9dFqZZBjl75b1?=
 =?us-ascii?Q?tbSE5e+jRfaPc/XiOoigpIn6Mxqpmhl+4SNbXzTEFSFRN0ohVMV4QpiikDC+?=
 =?us-ascii?Q?kEQhgihVvGTD5rxHD1WbkDlYI/R/eG8zS9TDx0cCWLnHumlDo+Y/XtD5fAev?=
 =?us-ascii?Q?lmocBdkbKsMmrlv//Q40dCGXv7uKQ3MZQmPv6/OoCocBmNXvgMePLAFBU3Ny?=
 =?us-ascii?Q?/67LgVbkZP9A8dgCeUfzD1Y=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71e1d882-0446-411e-1e39-08d9a8a14aa4
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB4021.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2021 01:34:54.9925
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hYT0L9lJZmp2XDuJu1ZplHZ8fZd8mdbygU4XNEvyxO/afRbGOnidw0yyV2wsUWLMQ+S6IzDE/c1P5Z7DfcZm6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4359
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

In function dc_sink_destruct, kfree will check pointer, no need
to check again.
This change is to cleanup the code a bit.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc_sink.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_sink.c b/drivers/gpu/drm/amd/display/dc/core/dc_sink.c
index a249a0e5edd0..4b5e4d8e7735 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_sink.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_sink.c
@@ -33,14 +33,6 @@
  * Private functions
  ******************************************************************************/
 
-static void dc_sink_destruct(struct dc_sink *sink)
-{
-	if (sink->dc_container_id) {
-		kfree(sink->dc_container_id);
-		sink->dc_container_id = NULL;
-	}
-}
-
 static bool dc_sink_construct(struct dc_sink *sink, const struct dc_sink_init_data *init_params)
 {
 
@@ -75,7 +67,7 @@ void dc_sink_retain(struct dc_sink *sink)
 static void dc_sink_free(struct kref *kref)
 {
 	struct dc_sink *sink = container_of(kref, struct dc_sink, refcount);
-	dc_sink_destruct(sink);
+	kfree(sink->dc_container_id);
 	kfree(sink);
 }
 
-- 
2.33.1