From:   Bernard Zhao <bernard@vivo.com>
To:     Thierry Reding <thierry.reding@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Bernard Zhao <bernard@vivo.com>
Subject: [PATCH] drm/tegra: remove no need NULL check before kfree
Date:   Mon, 15 Nov 2021 17:55:13 -0800
Message-Id: <20211116015513.27147-1-bernard@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?valL/Bjl1AIOUhzvVoCWKXeIdvEVgxRIh0HZYWa8DYHFVU1J2AHk7/q/w/6e?=
 =?us-ascii?Q?SI3YdRRl+dT/DKJTJwnoAxiZBgTB2TBw2MThQxst7+K3qkUqjo2lSi8KNqOi?=
 =?us-ascii?Q?A5w2Xa/h+R41A8d5U7yOD+ejGhg+y3yjX+ZJepw8fxp5FHkaZk9l/tBhWjwI?=
 =?us-ascii?Q?YitPfiqfbyeH6WxQsDQ9dQWy4QdX9WpNnp7bZ5nvFeunvv/foWTnnXgr6/5r?=
 =?us-ascii?Q?noif4hhKYTYgnTcFnEghm4gYet2vekLimtoT3O/AdLt2CLuW6vgM/m8izeJy?=
 =?us-ascii?Q?aBU56vKIX+Z58HJBKK7orH6FeflNxEaMrDZma7NgwdzzrF5JFi2v55qJPC1Y?=
 =?us-ascii?Q?bHNqDBe4fYBuGojLJ+/4iVnrasICIe1TO8jKUY584OLBUVWj5nKYA/hF6TxT?=
 =?us-ascii?Q?Qo3uTqIVKLOJf0eLZKc9OpE2hHz1LuCzLh80LCAaV6c4fy7OlrcFd2vHZHKn?=
 =?us-ascii?Q?KTj1dKHpNYIHbgRwnxdyJG1vGJvyjxT49ydsMRfaGgzYapRhk8s6zQ4zdRt8?=
 =?us-ascii?Q?gJkLu3Ypt9tFjyhcPtOw7J2t0CIDdqru3+FTagd6TBNw0adCCHILxU8RGLKS?=
 =?us-ascii?Q?JBxPxerCgpZKlfFbCqxtSQxc6bszT0xwn+JmnW7UKdFDDZQLfsRRQJ+KG1TL?=
 =?us-ascii?Q?E+19H5pA47tBRz9AiJPuenwn9FLRf1HRh9zWNrLC9JwN6OipYevE7HE2WlUC?=
 =?us-ascii?Q?bsXmcs/XPcHQQq84CyqyeOw28VGpR2YVL+0nNn25vsrc1KA4jf/YjRdNCYUW?=
 =?us-ascii?Q?J4iRdeO8OdwIRwzbDcoIzORAFHIjQmypSnAgviRnJciwlpMMLWntyFUTcPWJ?=
 =?us-ascii?Q?enNszGeC+0AoAJgULgh0vCXui83hA6/vHcwDwn/MSTSnp7JgF5KY8ZBu9BvS?=
 =?us-ascii?Q?Hk6ndb7thpXWmA+EyLn+bc/CUdCqE4gvFDNWBYwh/LNv4PDHY94kqaHAmb8S?=
 =?us-ascii?Q?CJqPjV5y7CWc1ZupI1dyo0dnW4Jn3TM71UsrUYTbC+UhVu4jLp+D3gbOOF4G?=
 =?us-ascii?Q?Cp8B5junJkp96W/aO5ZS5y1Zho7wURt5pQFGK0vkHbJDMG0R4EccsCIiF9QE?=
 =?us-ascii?Q?eMZuoGgtRg0c701MJAchciaoRc9kiHlNsr4McXqFY/uHI6jsW5Z1ozVnA+nZ?=
 =?us-ascii?Q?f3RnrU+fOGh9IbkYWeDUuXMEE/kE/h9W0mlvpPVZygQ86DcCH95jjtDM6yda?=
 =?us-ascii?Q?zDUVNJG3guuuqTSzijjB5vpOuYvDMGTx/MkWyjBDR4Lbb7jDMoXA0DjW8s4j?=
 =?us-ascii?Q?tM5jgIrnP6xZJSwkal+tJsO50ITGhBpbuRuMWlOdVaDURwciP8f97BWFlmN6?=
 =?us-ascii?Q?g/Hju05fuPbV3KvvOwtolSaiGTblwa7dilZjjo2PPIUykgjqF+HD2/LO46b+?=
 =?us-ascii?Q?ey/lnwRw4RCsGgLTpxIsI4S9n1F8+Kfj7dYw3tsWFfIKiZ+9HrNuU7icd+iG?=
 =?us-ascii?Q?k0i+2zwMrvORNnzNjsSJhX/YiSPY/C3TYBPYztx5IiRiaSIB9GH+I2Lrg6Q3?=
 =?us-ascii?Q?+g1oqgYVR84dSXI5p2Adkxf3QRgd2UsYVmJWozmwAMJ5YgJ6vUFq5MFbRO09?=
 =?us-ascii?Q?ZlrZBOyspi/jIZn2xrB2L5Qd+A5RQNd0xK8nJvi1nW93R+TRL3n9r3h77EjY?=
 =?us-ascii?Q?L2JGB8G2ebHflwTlRzoN3Os=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ae98262-3383-4b60-a810-08d9a8a42864
X-MS-Exchange-CrossTenant-AuthSource: PSAPR06MB4021.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2021 01:55:25.7335
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RAp0469j2LO3s54MIhzQKO9p+kVO7IljvjeX+5WLfkk2jAP5PeqKv++tBHK5e7qzrDN5GPxl9JAZRrL+qj1YPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PU1PR06MB2117
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This change is to cleanup the code a bit.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/gpu/drm/tegra/submit.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/tegra/submit.c b/drivers/gpu/drm/tegra/submit.c
index 776f825df52f..c2fc9677742e 100644
--- a/drivers/gpu/drm/tegra/submit.c
+++ b/drivers/gpu/drm/tegra/submit.c
@@ -608,12 +608,10 @@ int tegra_drm_ioctl_channel_submit(struct drm_device *drm, void *data,
 	if (job_data && job_data->used_mappings) {
 		for (i = 0; i < job_data->num_used_mappings; i++)
 			tegra_drm_mapping_put(job_data->used_mappings[i].mapping);
-
-		kfree(job_data->used_mappings);
 	}
 
-	if (job_data)
-		kfree(job_data);
+	kfree(job_data->used_mappings);
+	kfree(job_data);
 put_bo:
 	gather_bo_put(&bo->base);
 unlock:
-- 
2.33.1