Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70589C433EF for ; Tue, 16 Nov 2021 02:09:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D28C6141B for ; Tue, 16 Nov 2021 02:09:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245031AbhKPCMI (ORCPT ); Mon, 15 Nov 2021 21:12:08 -0500 Received: from mail.kernel.org ([198.145.29.99]:40726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238089AbhKORym (ORCPT ); Mon, 15 Nov 2021 12:54:42 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F2DB16327E; Mon, 15 Nov 2021 17:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1636997573; bh=CaENJ6ArXgaoAx/3ZZd9sL+dCs/vCIBBdf053UZN8DU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VaHtmkEuvCQktKQFVWbqGxme8L+BPNOYK6i4xVBCktlCj4C8OL2VKwMtIylTSjH7F pANJ1a5spXd6vlyzx1ddRavebcTt2D/15sUnvun/kWMvYMwvKFAksY++GiXpZxICAw ROIvWLeTxBh4dzWhP6UZsoBJD7A4l1/7GM62tyu8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+4d3749e9612c2cfab956@syzkaller.appspotmail.com, Rajat Asthana , Sean Young , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.10 198/575] media: mceusb: return without resubmitting URB in case of -EPROTO error. Date: Mon, 15 Nov 2021 17:58:43 +0100 Message-Id: <20211115165350.557049534@linuxfoundation.org> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211115165343.579890274@linuxfoundation.org> References: <20211115165343.579890274@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rajat Asthana [ Upstream commit 476db72e521983ecb847e4013b263072bb1110fc ] Syzkaller reported a warning called "rcu detected stall in dummy_timer". The error seems to be an error in mceusb_dev_recv(). In the case of -EPROTO error, the routine immediately resubmits the URB. Instead it should return without resubmitting URB. Reported-by: syzbot+4d3749e9612c2cfab956@syzkaller.appspotmail.com Signed-off-by: Rajat Asthana Signed-off-by: Sean Young Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/rc/mceusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/rc/mceusb.c b/drivers/media/rc/mceusb.c index 5642595a057ec..8870c4e6c5f44 100644 --- a/drivers/media/rc/mceusb.c +++ b/drivers/media/rc/mceusb.c @@ -1386,6 +1386,7 @@ static void mceusb_dev_recv(struct urb *urb) case -ECONNRESET: case -ENOENT: case -EILSEQ: + case -EPROTO: case -ESHUTDOWN: usb_unlink_urb(urb); return; -- 2.33.0