MIME-Version: 1.0
References: <20211115020850.3154366-1-rkovhaev@gmail.com>
In-Reply-To: <20211115020850.3154366-1-rkovhaev@gmail.com>
From:   Muchun Song <songmuchun@bytedance.com>
Date:   Tue, 16 Nov 2021 10:54:53 +0800
Message-ID: <CAMZfGtXqxe6Sf62s2Uk8pYOj-L=rUB4viHJ04YPFQOTSN0zBLw@mail.gmail.com>
Subject: Re: [PATCH] mm: kmemleak: slob: respect SLAB_NOLEAKTRACE flag
To:     Rustam Kovhaev <rkovhaev@gmail.com>
Cc:     Vlastimil Babka <vbabka@suse.cz>, Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        Greg KH <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Nov 15, 2021 at 10:09 AM Rustam Kovhaev <rkovhaev@gmail.com> wrote:
>
> When kmemleak is enabled for SLOB, system does not boot and does not
> print anything to the console. At the very early stage in the boot
> process we hit infinite recursion from kmemleak_init() and eventually
> kernel crashes.
> kmemleak_init() specifies SLAB_NOLEAKTRACE for KMEM_CACHE(), but
> kmem_cache_create_usercopy() removes it because CACHE_CREATE_MASK is not
> valid for SLOB.
> Let's fix CACHE_CREATE_MASK and make kmemleak work with SLOB
>
> Fixes: d8843922fba4 ("slab: Ignore internal flags in cache creation")
> Signed-off-by: Rustam Kovhaev <rkovhaev@gmail.com>

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.