Message-ID: <39236708-f668-e99e-e749-6b7b863241a8@gmail.com>
Date:   Tue, 16 Nov 2021 09:54:52 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH] staging: r8188eu: fix array_size.cocci warning
Content-Language: en-US
To:     Guo Zhengkui <guozhengkui@vivo.com>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Michael Straube <straube.linux@gmail.com>,
        "open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
        open list <linux-kernel@vger.kernel.org>
Cc:     kernel@vivo.com
References: <20211116064124.8833-1-guozhengkui@vivo.com>
From:   Pavel Skripkin <paskripkin@gmail.com>
In-Reply-To: <20211116064124.8833-1-guozhengkui@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/16/21 09:41, Guo Zhengkui wrote:
> diff --git a/drivers/staging/r8188eu/core/rtw_rf.c b/drivers/staging/r8188eu/core/rtw_rf.c
> index 2ec56012516e..e704092d31d0 100644
> --- a/drivers/staging/r8188eu/core/rtw_rf.c
> +++ b/drivers/staging/r8188eu/core/rtw_rf.c
> @@ -35,7 +35,7 @@ static struct ch_freq ch_freq_map[] = {
>   	{216, 5080},/* Japan, means J16 */
>   };
>   
> -static int ch_freq_map_num = (sizeof(ch_freq_map) / sizeof(struct ch_freq));
> +static int ch_freq_map_num = ARRAY_SIZE(ch_freq_map);
>   
>   u32 rtw_ch2freq(u32 channel)
>   {
> 

Hm, do we need this variable to be static? It's used only in 2 
expressions in rtw_ch2freq() (and 2nd one can be removed by 
per-initializing freq with 2412).

I think, it can be places on stack to reduce binary size.


With regards,
Pavel Skripkin