Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
From:   Alistair Popple <apopple@nvidia.com>
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     Jason Gunthorpe <jgg@nvidia.com>, <jglisse@redhat.com>,
        <jhubbard@nvidia.com>, <ziy@nvidia.com>, <rcampbell@nvidia.com>,
        <Felix.Kuehling@amd.com>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/hmm.c: Allow VM_MIXEDMAP to work with hmm_range_fault
Date:   Tue, 16 Nov 2021 18:15:34 +1100
Message-ID: <5228339.iium7KxlgL@nvdebian>
In-Reply-To: <20211115204842.78180ec7f4b0f51b538bbf55@linux-foundation.org>
References: <20211104012001.2555676-1-apopple@nvidia.com> <5535346.2Y9IAguWGx@nvdebian> <20211115204842.78180ec7f4b0f51b538bbf55@linux-foundation.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2021 07:15:38.9315
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 335f4c3e-c97e-4a20-45d4-08d9a8d0e48f
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT050.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0045
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, 16 November 2021 3:48:42 PM AEDT Andrew Morton wrote:
> On Mon, 8 Nov 2021 18:58:01 +1100 Alistair Popple <apopple@nvidia.com> wrote:
> 
> > On Friday, 5 November 2021 11:25:57 PM AEDT Jason Gunthorpe wrote:
> > > On Thu, Nov 04, 2021 at 12:20:01PM +1100, Alistair Popple wrote:
> > > > hmm_range_fault() can be used instead of get_user_pages() for devices
> > > > which allow faulting however unlike get_user_pages() it will return an
> > > > error when used on a VM_MIXEDMAP range.
> > > > 
> > > > To make hmm_range_fault() more closely match get_user_pages() remove
> > > > this restriction. This requires dealing with the !ARCH_HAS_PTE_SPECIAL
> > > > case in hmm_vma_handle_pte(). Rather than replicating the logic of
> > > > vm_normal_page() call it directly and do a check for the zero pfn
> > > > similar to what get_user_pages() currently does.
> > > > 
> > > > Also add a test to hmm selftest to verify functionality.
> > > 
> > > Please add a fixes line
> > 
> > This has been the case since hmm_vma_get_pfns() was first introduced. Therefore
> > the fixes line is:
> > 
> > Fixes: da4c3c735ea4 ("mm/hmm/mirror: helper to snapshot CPU page table")
> > 
> > Should I send a v2 adding that tag or does Andrew normally pick these up along
> > with the Reviewed-by?
> 
> I got it.
> 
> It needed a bit of rework due to the newly-added !pte_devmap() change
> in hmm_vma_handle_pte().  Please check carefully?

Thanks. The rework looks good to me - changing pte_special() to
vm_insert_page() does not change the logic of the !pte_devmap() change. In
either case the value of pte_special() or vm_insert_page() is ignored when
pte_devmap()==True as intended by the !pte_devmap() change.

For good measure I rerun the HMM selftest as well.

> From: Alistair Popple <apopple@nvidia.com>
> Subject: mm/hmm.c: Allow VM_MIXEDMAP to work with hmm_range_fault
> 
> hmm_range_fault() can be used instead of get_user_pages() for devices
> which allow faulting however unlike get_user_pages() it will return an
> error when used on a VM_MIXEDMAP range.
> 
> To make hmm_range_fault() more closely match get_user_pages() remove
> this restriction. This requires dealing with the !ARCH_HAS_PTE_SPECIAL
> case in hmm_vma_handle_pte(). Rather than replicating the logic of
> vm_normal_page() call it directly and do a check for the zero pfn
> similar to what get_user_pages() currently does.
> 
> Also add a test to hmm selftest to verify functionality.
> 
> Link: https://lkml.kernel.org/r/20211104012001.2555676-1-apopple@nvidia.com
> Fixes: da4c3c735ea4 ("mm/hmm/mirror: helper to snapshot CPU page table")
> Signed-off-by: Alistair Popple <apopple@nvidia.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Cc: Jerome Glisse <jglisse@redhat.com>
> Cc: John Hubbard <jhubbard@nvidia.com>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: Ralph Campbell <rcampbell@nvidia.com>
> Cc: Felix Kuehling <Felix.Kuehling@amd.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  lib/test_hmm.c                         |   24 +++++++++++++
>  mm/hmm.c                               |    5 +-
>  tools/testing/selftests/vm/hmm-tests.c |   42 +++++++++++++++++++++++
>  3 files changed, 69 insertions(+), 2 deletions(-)
> 
> --- a/lib/test_hmm.c~mm-hmmc-allow-vm_mixedmap-to-work-with-hmm_range_fault
> +++ a/lib/test_hmm.c
> @@ -1086,9 +1086,33 @@ static long dmirror_fops_unlocked_ioctl(
>  	return 0;
>  }
>  
> +static int dmirror_fops_mmap(struct file *file, struct vm_area_struct *vma)
> +{
> +	unsigned long addr;
> +
> +	for (addr = vma->vm_start; addr < vma->vm_end; addr += PAGE_SIZE) {
> +		struct page *page;
> +		int ret;
> +
> +		page = alloc_page(GFP_KERNEL | __GFP_ZERO);
> +		if (!page)
> +			return -ENOMEM;
> +
> +		ret = vm_insert_page(vma, addr, page);
> +		if (ret) {
> +			__free_page(page);
> +			return ret;
> +		}
> +		put_page(page);
> +	}
> +
> +	return 0;
> +}
> +
>  static const struct file_operations dmirror_fops = {
>  	.open		= dmirror_fops_open,
>  	.release	= dmirror_fops_release,
> +	.mmap		= dmirror_fops_mmap,
>  	.unlocked_ioctl = dmirror_fops_unlocked_ioctl,
>  	.llseek		= default_llseek,
>  	.owner		= THIS_MODULE,
> --- a/mm/hmm.c~mm-hmmc-allow-vm_mixedmap-to-work-with-hmm_range_fault
> +++ a/mm/hmm.c
> @@ -300,7 +300,8 @@ static int hmm_vma_handle_pte(struct mm_
>  	 * Since each architecture defines a struct page for the zero page, just
>  	 * fall through and treat it like a normal page.
>  	 */
> -	if (pte_special(pte) && !pte_devmap(pte) &&
> +	if (!vm_normal_page(walk->vma, addr, pte) &&
> +	    !pte_devmap(pte) &&
>  	    !is_zero_pfn(pte_pfn(pte))) {
>  		if (hmm_pte_need_fault(hmm_vma_walk, pfn_req_flags, 0)) {
>  			pte_unmap(ptep);
> @@ -518,7 +519,7 @@ static int hmm_vma_walk_test(unsigned lo
>  	struct hmm_range *range = hmm_vma_walk->range;
>  	struct vm_area_struct *vma = walk->vma;
>  
> -	if (!(vma->vm_flags & (VM_IO | VM_PFNMAP | VM_MIXEDMAP)) &&
> +	if (!(vma->vm_flags & (VM_IO | VM_PFNMAP)) &&
>  	    vma->vm_flags & VM_READ)
>  		return 0;
>  
> --- a/tools/testing/selftests/vm/hmm-tests.c~mm-hmmc-allow-vm_mixedmap-to-work-with-hmm_range_fault
> +++ a/tools/testing/selftests/vm/hmm-tests.c
> @@ -1251,6 +1251,48 @@ TEST_F(hmm, anon_teardown)
>  /*
>   * Test memory snapshot without faulting in pages accessed by the device.
>   */
> +TEST_F(hmm, mixedmap)
> +{
> +	struct hmm_buffer *buffer;
> +	unsigned long npages;
> +	unsigned long size;
> +	unsigned char *m;
> +	int ret;
> +
> +	npages = 1;
> +	size = npages << self->page_shift;
> +
> +	buffer = malloc(sizeof(*buffer));
> +	ASSERT_NE(buffer, NULL);
> +
> +	buffer->fd = -1;
> +	buffer->size = size;
> +	buffer->mirror = malloc(npages);
> +	ASSERT_NE(buffer->mirror, NULL);
> +
> +
> +	/* Reserve a range of addresses. */
> +	buffer->ptr = mmap(NULL, size,
> +			   PROT_READ | PROT_WRITE,
> +			   MAP_PRIVATE,
> +			   self->fd, 0);
> +	ASSERT_NE(buffer->ptr, MAP_FAILED);
> +
> +	/* Simulate a device snapshotting CPU pagetables. */
> +	ret = hmm_dmirror_cmd(self->fd, HMM_DMIRROR_SNAPSHOT, buffer, npages);
> +	ASSERT_EQ(ret, 0);
> +	ASSERT_EQ(buffer->cpages, npages);
> +
> +	/* Check what the device saw. */
> +	m = buffer->mirror;
> +	ASSERT_EQ(m[0], HMM_DMIRROR_PROT_READ);
> +
> +	hmm_buffer_free(buffer);
> +}
> +
> +/*
> + * Test memory snapshot without faulting in pages accessed by the device.
> + */
>  TEST_F(hmm2, snapshot)
>  {
>  	struct hmm_buffer *buffer;
> _
> 
> 
>