Date:   Tue, 16 Nov 2021 11:32:37 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     roopa@nvidia.com, nikolay@nvidia.com, davem@davemloft.net,
        kuba@kernel.org, bridge@lists.linux-foundation.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net: bridge: Slightly optimize 'find_portno()'
Message-ID: <20211116083237.GH26989@kadam>
References: <00c39d09c8df7ad0673bf2043f6566d6ef08b789.1636916479.git.christophe.jaillet@wanadoo.fr>
 <20211115123534.GD26989@kadam>
 <b3c93506-7dc8-a5fe-6cfc-938fc88b9f07@wanadoo.fr>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b3c93506-7dc8-a5fe-6cfc-938fc88b9f07@wanadoo.fr>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?7c5BZ83/huPmFcErR6lJNQbQtLF/Sir8oYl8RbUj/GrxSijE3NHBCxkii7?=
 =?iso-8859-1?Q?ZEyyqQQbZbrMdpPog7k8dDnO3qt5hgLRi7+Ei//2ngmXxafEKqLk/lEufj?=
 =?iso-8859-1?Q?wGefAYJXbwxDm39bm9kpNpZf0xH/ohRPR8gif5+EwwkpylCS88+JtzDkqB?=
 =?iso-8859-1?Q?s3H6RO9RBoDG7JsVrHNVbkFQA7mM6hEfE1fVnjCIC3DE+QcZElMF9xVNML?=
 =?iso-8859-1?Q?nzA/E3yYB9hwuWu67LDOHrvxxySOoD+WMldpEHkSTWW+BX0oJN22HOKIFH?=
 =?iso-8859-1?Q?7HlMrDHjAjslWZP5bSkKGIIkFucFJ0kro0whMNzeDJbaMrx8IGsmy00xWf?=
 =?iso-8859-1?Q?T0M+eDC/fw+oFKCpZe1So+QWac8Fz9l72q0bt07t7Lf2EnuLr6kOqQm0uJ?=
 =?iso-8859-1?Q?5PSCN5nF9fIWVZhRwNI9LnbZPTmhrFR7gAR3wpecXgm2Jj+eMwU9LuUYzX?=
 =?iso-8859-1?Q?wPDzems5XgC4EQYVfX7I2u2Qeanay7BX7VeFCAD9kW19fsoGRYJjHQykWL?=
 =?iso-8859-1?Q?ZXToLAuhXCuzaMQVnZAPDTQW9RXSyf2k3YyPpg6YNdKLlijGiIDouSqXAS?=
 =?iso-8859-1?Q?U59NC5tJeBl3oDgRRa4tZqf/ZsZlynul5eC4BUMjEm2fD7mLzP+/bvNWxm?=
 =?iso-8859-1?Q?SlxY2crDfuz5t9zO0X17bun7uiMx4lVRCfrKk2kEZcffhFXXF7w3NVVCJ1?=
 =?iso-8859-1?Q?RlewmkjQNBGJGbIa5AXvAY9yJNaviZePl62LNGSiLxm4r9hduueaRBBPaU?=
 =?iso-8859-1?Q?944+4+pJlmBl0qi4GGWpMfeXbsaiovD93qTxJsXbUJb7U6ko70ZZUG7ezn?=
 =?iso-8859-1?Q?ZUwQXALZpSZtfGej4HtGU2BYdBdNY1PydnzFRKLf+eKYwZmGegUV37gv55?=
 =?iso-8859-1?Q?H66BbTYqMzsEcHHAZLJAmQjcbOu1THEyF+tnmJHEm2JhpNNMVnvV9MI6k8?=
 =?iso-8859-1?Q?VRknhsMqs+nRyBcZGMDda4ZUIX0+EXrCa9npIaJsAv6xshOfJ0tantX44N?=
 =?iso-8859-1?Q?8Z2ZSA3ClgxLwEXVywMoX8DUH7w07wJ8djpSMw5C/ztj20tJrWqVkFNe/b?=
 =?iso-8859-1?Q?3FUE9O7PJ/ppokpwonzVyx5+xOYsbqRACfUv54FCjR1wyJnbee/dyOCAqA?=
 =?iso-8859-1?Q?tQgaJXnfjKm8r7oeSXK1dqpQBm4x6/SjbBrmrXse1e2tWuP/DLsvV7N1Zx?=
 =?iso-8859-1?Q?wE8wS7ngTHCzX2Nu76mlOgj4KuYpv6y4H6+FKT5xVUAst3hdbrjk/nlXir?=
 =?iso-8859-1?Q?iVDHh/O8Wt6vCPPOS50b5nZB+kXR1ESKykMl0w2Y3X8ZIPeLUjqSnQpauh?=
 =?iso-8859-1?Q?tdAXokeWvArA9nEZKE7Ii1x91q0gvdyjaiRQZTD0D6XqizJ/g9Rd1sZ3EL?=
 =?iso-8859-1?Q?muYsHPx851+9P2y6puH1hBr02rjMuiZaXwzhXQFBI1An7pPpt3G6D1lLI4?=
 =?iso-8859-1?Q?1U+fQo35324w/MjeEZ5yPg7n0LZEPwYp/HzEq2LNDRoWdLM874OztiJoot?=
 =?iso-8859-1?Q?9gA6Huino2wjrARlrRIMtg+R/xvddrUAKal3kcbtw7H1LQ9cdslD72qNwS?=
 =?iso-8859-1?Q?bmwS5zFlADza9s1ACajbqTLkxq9BMuDI6GczUtbg8rmlE3Vav8LvCtbx9Y?=
 =?iso-8859-1?Q?VJxwEOzSatroMO9Tx/imvgKVKD1M8xuYyx9/fH9g7OFaJlacL7sw7DWZEE?=
 =?iso-8859-1?Q?VaYWm8Y8ylqAdah8bpp9zKUL6T4shcoC1aB4zoF3pyLu3SxpHSwOk7Ov1N?=
 =?iso-8859-1?Q?THtlxAz0/3Q85XKnNhffGBaU0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a5b034a-849b-4652-4a18-08d9a8dbbf7d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2021 08:33:21.6337
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v77iE4rkTPvXn2NasPLEKNQSw7xjXXtIEaWmgEh0Ard2JN7XUoBoNaxyFoaVKHIosXnqn9pbBoqSA3AEKVMziuUCECg5AoIGFQgM0RDNFCY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2399
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10169 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 mlxscore=0
 phishscore=0 bulkscore=0 mlxlogscore=385 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111160043
X-Proofpoint-ORIG-GUID: fr4W52j6eLKhOEGKQvD90ww-MwoTt0Iq
X-Proofpoint-GUID: fr4W52j6eLKhOEGKQvD90ww-MwoTt0Iq
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 15, 2021 at 07:35:48PM +0100, Christophe JAILLET wrote:
> Le 15/11/2021 ? 13:35, Dan Carpenter a ?crit?:
> > On Sun, Nov 14, 2021 at 08:02:35PM +0100, Christophe JAILLET wrote:
> > > The 'inuse' bitmap is local to this function. So we can use the
> > > non-atomic '__set_bit()' to save a few cycles.
> > > 
> > > While at it, also remove some useless {}.
> > 
> > I like the {} and tend to add it in new code.  There isn't a rule about
> > this one way or the other.
> > 

[ heavily snipped ]

> 
> - checkpatch prefers the style without {}

Not for these.

> - Usually, greg k-h and Joe Perches give feed-back that extra {} should be
> removed.

I can't find any reference to that.

> - in https://www.kernel.org/doc/html/v5.13/process/coding-style.html, after
> "Rationale: K&R":
>    "Do not unnecessarily use braces where a single statement will do."

There are exceptions for readability.  For example, mutiline indents
get it whether they need or not.  Do while statements get braces.

Quite a lot of people don't use braces for list_for_each() unless it's
required, definitely, but I think it's allowable.

regards,
dan carpenter