From:   Jani Nikula <jani.nikula@linux.intel.com>
To:     Angus Ainslie <angus@akkea.ca>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>
Cc:     kernel@puri.sm, David Airlie <airlied@linux.ie>,
        Angus Ainslie <angus@akkea.ca>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org, ville.syrjala@linux.intel.com
Subject: Re: [PATCH] drm: drm_probe_helper: add modes upto 1920x1080
In-Reply-To: <20211115160135.25451-1-angus@akkea.ca>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20211115160135.25451-1-angus@akkea.ca>
Date:   Tue, 16 Nov 2021 10:44:14 +0200
Message-ID: <87czn01odd.fsf@intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Cc: Ville

On Mon, 15 Nov 2021, Angus Ainslie <angus@akkea.ca> wrote:
> Lots of monitors nowdays support more than 1024x768 so if the EDID is
> unknown then add resolutions upto 1920x1080.

IIUC it's supposed to be the fallback that's pretty much guaranteed to
work. What's going to happen if we add 1920x1080 and it fails?


BR,
Jani.

>
> Signed-off-by: Angus Ainslie <angus@akkea.ca>
> ---
>  drivers/gpu/drm/drm_probe_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_probe_helper.c b/drivers/gpu/drm/drm_probe_helper.c
> index e7e1ee2aa352..5ad66ae9916e 100644
> --- a/drivers/gpu/drm/drm_probe_helper.c
> +++ b/drivers/gpu/drm/drm_probe_helper.c
> @@ -517,7 +517,7 @@ int drm_helper_probe_single_connector_modes(struct drm_connector *connector,
>  
>  	if (count == 0 && (connector->status == connector_status_connected ||
>  			   connector->status == connector_status_unknown))
> -		count = drm_add_modes_noedid(connector, 1024, 768);
> +		count = drm_add_modes_noedid(connector, 1920, 1080);
>  	count += drm_helper_probe_add_cmdline_mode(connector);
>  	if (count == 0)
>  		goto prune;

-- 
Jani Nikula, Intel Open Source Graphics Center