Message-ID: <8a5e44aa-243f-3a9d-e917-09cd3cf6609a@nvidia.com>
Date:   Tue, 16 Nov 2021 00:51:13 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH RFC v2 2/2] mm: Rework swap handling of zap_pte_range
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>, Peter Xu <peterx@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        David Hildenbrand <david@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Yang Shi <shy828301@gmail.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Hugh Dickins <hughd@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Alistair Popple <apopple@nvidia.com>,
        "Kirill A . Shutemov" <kirill@shutemov.name>
References: <20211115134951.85286-1-peterx@redhat.com>
 <20211115134951.85286-3-peterx@redhat.com>
 <YZJnTKKXDqKWZ6UP@casper.infradead.org>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <YZJnTKKXDqKWZ6UP@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUoxKzFCQ1RmbHR3WXdNYmZwakZoMmY4TEcrS1k3bmhGM252YUVYQk1pOFE4?=
 =?utf-8?B?U1FzQThINEJSaXoyUDM2Zm4xS3F2cm8vQWY4MHBwajZPTmRLTEpUaUtuUmF2?=
 =?utf-8?B?ajlIMEpieEM0cWlha1N1ZkFUektsR2JsTGdTMVlqWVNGeERSUk1uQVl3QTdD?=
 =?utf-8?B?Y243Tis5RG1RSFg1NTJGM2ZFNnQ0SzMzcnZzN1RZSTVteW9lSC9DSnIzb0kx?=
 =?utf-8?B?Nkd4a2dkNWh4TlE1ZHhMVm9IcVFQRWEvMEV4b0o2OThxMzFjOVdodnZPUER0?=
 =?utf-8?B?eng3cmlTdTIwbWhTZHRnUFg3QnlablBuS2VQK3hpdy9TQTlCWEJ2TFNGckRY?=
 =?utf-8?B?U3lndE9vSm9iYzQyY20wbnptbzBVRXMxU0xLOVRSWXVYYjF1WWwzemRJZnJ3?=
 =?utf-8?B?emlYVEtkQll0OXdvWm1UdWZpR3VoZVBhMzV2T0hNZFRJUkhoWG1RRXBPTElP?=
 =?utf-8?B?V0pDRzNyTm8xNGY4eE01UENpNWoraERpUzJUTlZrSVUvT3NVUHl6RWtuTnVD?=
 =?utf-8?B?KzA3TFhIMFBheDZVbU1EcDRES2wraGNPWm5wenVuRGdOaDdIRGpybTN6RlFp?=
 =?utf-8?B?UDUxL0tWeDR2WXdkVlNGaVJHbEtzVllRenN3MCtJU0ozb0trSmxCNnZQTGlH?=
 =?utf-8?B?UGNpWEFLMXVLd21OOVRib05SVExYVGIzOExOa1QzV3hmS0ErUWhxakhLYXlM?=
 =?utf-8?B?b0xLazZHOUZiSFBwS01hRHVpL2N5ZEwxVHNkTG5QRHBNcmZGKzhHWk5ZOWZQ?=
 =?utf-8?B?bCt0bm1odHlETjJpZ2tHWkVaTURQYkVGUktFd1lZSU5GaFpMRklhWWtGYk5x?=
 =?utf-8?B?NTh0bEwvMGtHcUc4U3RLM1pueWM3QVpCWFRqdXltdWFmV3VRWGU4MVZkVGZM?=
 =?utf-8?B?VjhpWWVUb0tvZUVxWEJBb1JjYW0zdU9BZmRBSFFwYkFraEQxNjBHcWRTWVFl?=
 =?utf-8?B?b1NCQzZlUkY5WU1heThCbU9zQjhjZTYvTmlqWStKR2Y1cGhzMk5GNk9Ea2pS?=
 =?utf-8?B?MTZFNkgyRFFBMysxb3VlNUZuR3ZzYmphQXE0YzZYSThyVC9PZ0EvbDZZZTA1?=
 =?utf-8?B?L3pYeWFicTNlcWNGRnMvak9MbTQ5QjU3TkxJTUZTdEdpMVZiNlZudVVCSHht?=
 =?utf-8?B?b0R3UnpSMG9iaHhhWDJSZzdGbFhDejVkWTF3NjJnd2d0K1dNcnIyMUxPQ0RN?=
 =?utf-8?B?Q3Y3ang4SGJXc0NWQUVBYlhqQkZsZ3BndEFQK3FkeVI5SlRmakJsaTNNRlNF?=
 =?utf-8?B?a2Nwb1dxZ201VWVrZDNkQVNKS3dsY1pRcXpYc1NBSEhQNFRFSUVSb0NPL2gx?=
 =?utf-8?B?Zm51dDI1SFZONWdRK1JuSmYrN1FwMFVibGZZTGlsSVJwR29lUTlUZTd6NnRV?=
 =?utf-8?B?TDF0UklwWEJVQUsyK3hIMHlMbjVBWkp3NUNNT2RJajRDRXFMTERodDFIU3ZY?=
 =?utf-8?B?T3ZCOTJ0R3hoZjFvc09tdnZrR0prekZUSjZXcXRWZFp6Wk5GZ3p3cUhPaUts?=
 =?utf-8?B?a0xPUUthNm1lSHF0bWhvZktvUGJZVElqWSttT1VMM0FBL3ozbS9uTWlhWndh?=
 =?utf-8?B?NUVrNWlLdWNRVUVjR2dYdFRjNGJnU05HUWJvOEZpOFR4OFFySEhFV3V2TnBn?=
 =?utf-8?B?QkZDdmE3TUdhaksvbytPSGhvb0dMUUlJZzNRMy9STjhUZDZXcGhPSzBkR2s4?=
 =?utf-8?B?QkNmdlVLMG5wUkc0SFhFUkx3eWNtemxabzBTTGVaMUpBRGZhYzFYN1ZWUS9t?=
 =?utf-8?B?SVdyaThNZTFwZTl0ZlpwS2tKUXIwTWFuWXljekZmcXRUZ2l3dkFreTY3K2Nh?=
 =?utf-8?B?OVRqQVFsWG0wU2NyVGlDUlA1dllaMGZoNGlWaCtGRFdoUnRDME1KZTlzZmpu?=
 =?utf-8?B?UzJZanRVeHc1WEs1R0tETTNGYXQzai84SlhhcUltNk1QeFFHdkFIUXppVGt2?=
 =?utf-8?B?Q08zVmV3UGVscmRlRm41Y21VU3JWMldkaEhUcDNmTDlsRk85eXlUbmlVR0pJ?=
 =?utf-8?B?YnA3LzlDQys0NzlRVFVHdFNuZnFMZDNvZW5SdTlQUkl1dUUyc2dYMDJORDlL?=
 =?utf-8?B?N0FUd3JWZkV6b3dGbVUwNlRlZHhQTnBacGZScXVSdlRYN1p6MzZ4QmN4blln?=
 =?utf-8?B?N3lBU3VsSmtlWFFoY3BScUh1Y3RydDRvT3Y1SjBHYzkxcmFaM0MvNk9zWGdx?=
 =?utf-8?Q?GnXywyB17mZoHK66OcPzSOQ=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fb114d9-6fda-4eb2-e422-08d9a8de3f22
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2021 08:51:14.6636
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DcBNdFJ49mQwW/lSObK98yyzzb/z1JarNwhhPJxYu89/IWEINyFwgYCc0CCHjSxXrOJ462Nrn1X/jLY0bcCx1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3126
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/15/21 05:57, Matthew Wilcox wrote:
> On Mon, Nov 15, 2021 at 09:49:51PM +0800, Peter Xu wrote:
>> Clean the code up by merging the device private/exclusive swap entry handling
>> with the rest, then we merge the pte clear operation too.
>>
>> struct* page is defined in multiple places in the function, move it upward.
> 
> Is that actually a good thing?  There was a time when declaring

Yes. It is a very good thing. Having multiple cases of shadowed variables
(in this case I'm using programming language terminology, or what I
remember it as, anyway) provides lots of opportunities to create
hard-to-spot bugs.

> variables more locally helped compilers with liveness analysis and
> register allocation.  Compilers are probably smarter now.
> 

...as long as the above checks out, and I see from Peter's response that
we're OK.


thanks,
-- 
John Hubbard
NVIDIA