From:   Anand Ashok Dumbre <ANANDASH@xilinx.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        git <git@xilinx.com>, Michal Simek <michals@xilinx.com>,
        "rafael@kernel.org" <rafael@kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>
Subject: RE: [PATCH] device property: Add fwnode_iomap()
Thread-Topic: [PATCH] device property: Add fwnode_iomap()
Thread-Index: AQHX2keckvNuyh1x3kSfGREWzahA66wE4w4AgAD+5KA=
Date:   Tue, 16 Nov 2021 09:23:10 +0000
Message-ID: <BY5PR02MB6916AEC2CCB6EAE49A7FBC47A9999@BY5PR02MB6916.namprd02.prod.outlook.com>
References: <20211115173819.22778-1-anand.ashok.dumbre@xilinx.com>
 <YZKiJFpSU8kIK6Tq@kroah.com>
In-Reply-To: <YZKiJFpSU8kIK6Tq@kroah.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IhrV4hP+D4v48YB7J1c4RiqQRU7gCZMKtvJ5FMYSR7+1zmvifAGh2N8zA555?=
 =?us-ascii?Q?/JTP+dcwHjamzk6Lyxn9CT0hQLDqeqRAidM+vF+9caN0D9U5Gk9vR9llZtSh?=
 =?us-ascii?Q?Rh2cnJeAvm/XnqVbUA6sYmJnj8rQqXsiXWx/9dyxTnWyJCfJbbqGsZgne7On?=
 =?us-ascii?Q?ZotC1O8kdcVTT3s1mYFfgxjHzrkRy99wg7Ck2BjGWH/UUgzoi6/m/pNsoQrP?=
 =?us-ascii?Q?X3Atz1gjJsY12ioXuOUty10llcQb9u55xF8wMshH34UVgeGmisZ22hGg8fS7?=
 =?us-ascii?Q?QDlBEHYWy3QJRZ62ibsLXQWni+wgWF1wn8dVzOI9L1XyGpKQxQyR8jgfiIy8?=
 =?us-ascii?Q?5aWaBLEFh/GCXwHgZ4z3fSehX1N7sucdtPIJD9DjyFrr8ETBAlM6PiVOAQjN?=
 =?us-ascii?Q?Tkpn32iRgMk4aqM3XzkJn22Dlk0mpXa+NXVdCXGQHucfXBGTCbX457cTzdxS?=
 =?us-ascii?Q?C9uAOPB9+ixfJTqMBHhXwDHpH7uYmR3CyrjZiQMHdkrbzfw1YX2WeweuJAIK?=
 =?us-ascii?Q?r47nKBpT6ATbS4cdKZUQK84B0R8VxEtKEP1Ph6oIUwWgMsVVKjcqd1ktFkVo?=
 =?us-ascii?Q?CZAx0MyXgt8OUtrVqiXkxcgY8aGOv39DLniJZIHtPxqvgkB1t04jZIQNVo1j?=
 =?us-ascii?Q?eaw/u4TCdyKizQcVzEB4NMxv3kmkfEvw01sBWTCe9fiHzLXWaJ5KFw5RLSnd?=
 =?us-ascii?Q?i98e+4CaE5uDRikmtL4p0SzUmpzaR/bP373ZDO5RJEnKX5lUmH2Lb88gdN8V?=
 =?us-ascii?Q?NHyP6PEmtGoji80QH01uflllE9nsaF2Vf8+/owH9Xtensawp0dpsZAHEhMVc?=
 =?us-ascii?Q?5JT3ODVTN8xHtqZE9F195Bxud9s2L9m3r8WR88iZr5Xkf56g2vYExdzN4VAk?=
 =?us-ascii?Q?/Bqdw8c2DFBIl7f+7fKtA+iVKKNWLlQ2E56GAJ8nfWCJTL0wI+jfgkLzqanZ?=
 =?us-ascii?Q?0a7C00rucCboey60YDWMqLg4Kz2z18kzm7NIiQaHvowuPEMSQxQo/oSGhW8v?=
 =?us-ascii?Q?DFFBPpzge9OluweEjAZv2cjHe8QPpUKppJs8Lb5HUrP7Z6zg9wYkMj19BxTS?=
 =?us-ascii?Q?qyNQG/v/jJiWJVCPe9peVtFt19lPB7dBB5eSeVglcc3HdbZdh79YeWOeuZ6S?=
 =?us-ascii?Q?AlWmH6CBiXdoXEAxGiZ0/E59IKXx5/BtdHyKHqRwqDXXqHAW+G6r2A4xNdyO?=
 =?us-ascii?Q?NAaL74JLGXCNEuor/SjVoVk5LzvEZWlQRYfIcwXM31ovutuTy7/sqDqRZ7zG?=
 =?us-ascii?Q?DHIaOPkOw3/HERNZtI+baEDbrkxGeirdmvS+PdE9EYPbudf7XStYLOWfXxmV?=
 =?us-ascii?Q?bnt47fGVmZ6uCk3PCcbVR120M6bYIUM572VWWreToJVuJgPJzjFQo0VSqtgL?=
 =?us-ascii?Q?sM6mOtcD9BXjJ9p+W7S+ZKFEDXngdz/NUF2IcJeARMYH60FaHatFlCLAa55r?=
 =?us-ascii?Q?2tzI2AtFf7LkNNJCMMSSu8tFTNHrk5hWGwHYRyW8M2kiC+c6iNmrB9x+4bBx?=
 =?us-ascii?Q?yXxq7CcgBQ58f6E/4lntFLHHxOC0YuIwjQWaG3ryHtFCPDSIS1KQQD3A8NGV?=
 =?us-ascii?Q?czvOhdEqLQJwUy9RLi1fK0YPtUVVFirztGipbuqvrLvxZrUDMCKvDkIJ4kBO?=
 =?us-ascii?Q?aH8QSACdbFsuE06ooRuA58o=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR02MB6916.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0ac06a6-b5b2-46c5-83b1-08d9a8e2b50f
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2021 09:23:10.1552
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gTFJFF3ChTU1ZwgiGYR+UjxPMggFlDle4B8HiCqSbdqW5/jSPdhOsQaI0bOGdZWcZEkyGd0CrRb7gUn7kTfOZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB8628
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg,

Thanks for the review.

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Monday 15 November 2021 6:09 PM
> To: Anand Ashok Dumbre <ANANDASH@xilinx.com>
> Cc: linux-kernel@vger.kernel.org; jic23@kernel.org; lars@metafoo.de; linu=
x-
> iio@vger.kernel.org; git <git@xilinx.com>; Michal Simek
> <michals@xilinx.com>; rafael@kernel.org; linux-acpi@vger.kernel.org;
> andriy.shevchenko@linux.intel.com; heikki.krogerus@linux.intel.com
> Subject: Re: [PATCH] device property: Add fwnode_iomap()
>=20
> On Mon, Nov 15, 2021 at 05:38:19PM +0000, Anand Ashok Dumbre wrote:
> > This patch introduces a new helper routine - fwnode_iomap(), which
> > allows to map the memory mapped IO for a given device node.
> >
> > Signed-off-by: Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
> > ---
> >  drivers/base/property.c  | 15 +++++++++++++++
> > include/linux/property.h |  2 ++
> >  2 files changed, 17 insertions(+)
> >
> > diff --git a/drivers/base/property.c b/drivers/base/property.c index
> > 453918eb7390..9323e9b5de02 100644
> > --- a/drivers/base/property.c
> > +++ b/drivers/base/property.c
> > @@ -1021,6 +1021,21 @@ int fwnode_irq_get(const struct fwnode_handle
> > *fwnode, unsigned int index)  }  EXPORT_SYMBOL(fwnode_irq_get);
> >
> > +/**
> > + * fwnode_iomap - Maps the memory mapped IO for a given fwnode
> > + * @fwnode:	Pointer to the firmware node
> > + * @index:	Index of the IO range
> > + *
> > + * Returns a pointer to the mapped memory.
> > + */
> > +void __iomem *fwnode_iomap(struct fwnode_handle *fwnode, int
> index) {
> > +	if (is_of_node(fwnode))
> > +		return of_iomap(to_of_node(fwnode), index);
> > +
> > +	return NULL;
> > +}
> > +EXPORT_SYMBOL(fwnode_iomap);
> > +
> >  /**
> >   * fwnode_graph_get_next_endpoint - Get next endpoint firmware node
> >   * @fwnode: Pointer to the parent firmware node diff --git
> > a/include/linux/property.h b/include/linux/property.h index
> > 357513a977e5..9bb0b0155402 100644
> > --- a/include/linux/property.h
> > +++ b/include/linux/property.h
> > @@ -121,6 +121,8 @@ void fwnode_handle_put(struct fwnode_handle
> > *fwnode);
> >
> >  int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int
> > index);
> >
> > +void __iomem *fwnode_iomap(struct fwnode_handle *fwnode, int
> index);
> > +
> >  unsigned int device_get_child_node_count(struct device *dev);
> >
> >  static inline bool device_property_read_bool(struct device *dev,
> > --
> > 2.17.1
> >
>=20
> Also, always run scripts/checkpatch.pl before sending patches out so you
> do not get grumpy maintainers telling you to run scripts/checkpatch.pl
> on your patches :)
>=20

Sorry. Will do and also will send it as a part of my other driver series.

> thanks,
>=20
> greg k-h