Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965031AbXAJTD0 (ORCPT ); Wed, 10 Jan 2007 14:03:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965032AbXAJTD0 (ORCPT ); Wed, 10 Jan 2007 14:03:26 -0500 Received: from smtp.osdl.org ([65.172.181.24]:43127 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965031AbXAJTDZ (ORCPT ); Wed, 10 Jan 2007 14:03:25 -0500 Date: Wed, 10 Jan 2007 11:02:33 -0800 (PST) From: Linus Torvalds To: Jean Delvare cc: Roman Zippel , Andrey Borzenkov , Andrew Morton , linux-kernel@vger.kernel.org, Andy Whitcroft , Herbert Poetzl , Olaf Hering Subject: Re: .version keeps being updated In-Reply-To: <20070110181053.3b3632a8.khali@linux-fr.org> Message-ID: References: <20070109102057.c684cc78.khali@linux-fr.org> <20070109170550.AFEF460C343@tzec.mtu.ru> <20070109214421.281ff564.khali@linux-fr.org> <20070110181053.3b3632a8.khali@linux-fr.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1137 Lines: 33 On Wed, 10 Jan 2007, Jean Delvare wrote: > > This fixes the problem I reported. Thanks Roman! > > Linus, Andrew, if Roman's patch looks OK to you, can it please be > applied before 2.6.20 is released? I applied it, but looking closer at it, it becomes clear that Roman didn't understand the problem with that patch. This part: const char __init linux_banner[] = CANNOT work, because the stupid SuSE tool that look into the kernel binary searches for "Linux version " as the thing, and as such the "linux_banner" has to be the _first_ thing to trigger it for it to work. Which is why "__init" is wrong. It causes the linker to either put it at the end of the thing (which would break the SuSE tool). Alternatively it causes section mismatch problems ("init" and "const" don't work that well together), in which case it might work, but only due to toolchain bugs. Grr. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/