Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0EBFC433EF for ; Tue, 16 Nov 2021 11:06:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2B3863241 for ; Tue, 16 Nov 2021 11:06:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234540AbhKPLJC (ORCPT ); Tue, 16 Nov 2021 06:09:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32031 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234669AbhKPLIG (ORCPT ); Tue, 16 Nov 2021 06:08:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637060708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wbmIBzriyMiidR902JIsFIskMTSm37Jsy4HrcpI1HxQ=; b=eHGA0RCmrzjTwd5ixyoHC46+YL0a+/VvIkVv463sZgEa6C7GjS8srJi6n+raSMjQwYxdWS oKss2UIPlIMyeo/vKVjUYJuq3n7cpAuYkQZ/xdhrbi5NGCenjx8Zn/mpECVGbr/YhnueF6 Mf6omJOKZ1Eco84YqXy3k4T6upUprUA= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-G_O2I1joNGeBke2hDQyuug-1; Tue, 16 Nov 2021 06:05:05 -0500 X-MC-Unique: G_O2I1joNGeBke2hDQyuug-1 Received: by mail-ed1-f72.google.com with SMTP id v10-20020aa7d9ca000000b003e7bed57968so5611121eds.23 for ; Tue, 16 Nov 2021 03:05:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=wbmIBzriyMiidR902JIsFIskMTSm37Jsy4HrcpI1HxQ=; b=IFXR2MI3g4KVCN/fJs6OEq89VBVT/4+wa/k/XL61VFG1V1kqIEzxnqOQU9kVFGzRmJ MBj+qWZf7uWdlmlz9icDHfVyhHMnY2JCbM0ldn0rjmEqLQBSo1hXpCbO3G7JOgmJ+tmZ LapaoBse8r0itbF1iTktu8JKoyDHMwbTrH9dXee4xP/ERHJ50FcVOUx2C/aejUdnfo0D V6wVpUMQrayvxCmPwTCS17YAa4EkxwHR5DfTCVSlAuDpPKrJPQWmvJR9lgF2BObQtE0N T0P8NekLWFoSVX1elhrthuwxOtr4avs4jLzaCPcGp/WSPjcvLt7cAo0Xe+hkv3DQfTdd y3SQ== X-Gm-Message-State: AOAM530rxMcC1DosJOATEZiZhNWH9l6mFgyFzsaSUTQc2nwIgh+rI5ql qiY+3OQMhedxg2WB4n9iD9CP0mJXlL15VOJ95EdKkEODf91GoTrkUJdvRs9qvY8soPNmYp9Jeu0 UO56pGYhLUt6tbEPMp0nYqw1k X-Received: by 2002:a17:907:160b:: with SMTP id hb11mr9113610ejc.336.1637060704462; Tue, 16 Nov 2021 03:05:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJzzV6WFQipfuLRwIm3t2+exoHw4xftYYeP1WniIIsmjPL9BrCl5c8f4Sd8heJ8XXEUWJ6Yizg== X-Received: by 2002:a17:907:160b:: with SMTP id hb11mr9113572ejc.336.1637060704229; Tue, 16 Nov 2021 03:05:04 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1054:9d19:e0f0:8214? (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id m22sm6649409eda.97.2021.11.16.03.05.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Nov 2021 03:05:03 -0800 (PST) Message-ID: <684c11bc-3703-1de9-3073-96701405cd2c@redhat.com> Date: Tue, 16 Nov 2021 12:05:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 00/20] power-suppy/i2c/extcon: Fix charger setup on Xiaomi Mi Pad 2 and Lenovo Yogabook Content-Language: en-US To: Andy Shevchenko Cc: "Rafael J . Wysocki" , Mika Westerberg , Mark Gross , Andy Shevchenko , Wolfram Sang , Sebastian Reichel , MyungJoo Ham , Chanwoo Choi , Ard Biesheuvel , Len Brown , ACPI Devel Maling List , Yauhen Kharuzhy , Tsuchiya Yuto , Platform Driver , linux-i2c , Linux PM , Linux Kernel Mailing List , linux-efi References: <20211114170335.66994-1-hdegoede@redhat.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/16/21 12:00, Andy Shevchenko wrote: > On Sun, Nov 14, 2021 at 7:03 PM Hans de Goede wrote: >> >> Hi All, >> >> This is version 2 of my series previously titled: >> "[PATCH 00/13] power-suppy/i2c/extcon: Add support for cht-wc PMIC >> without USB-PD support". >> >> So far almost all the kernel code surrounding the Cherry Trail Whiskey Cove >> PMIC has been developed on the GPD win / pocket devices and it has various >> assumption based on that. In the mean time I've learned (and gotten access >> to) about 2 more designs and none of the 3 now known designs use a single >> standard setup for the charger, fuel-gauge and other chips surrounding the >> PMIC / charging+data USB port: >> >> 1. The GPD Win and GPD Pocket mini-laptops, these are really 2 models >> but the Pocket re-uses the GPD Win's design in a different housing: >> >> The WC PMIC is connected to a TI BQ24292i charger, paired with >> a Maxim MAX17047 fuelgauge + a FUSB302 USB Type-C Controller + >> a PI3USB30532 USB switch, for a fully functional Type-C port. >> >> 2. The Xiaomi Mi Pad 2: >> >> The WC PMIC is connected to a TI BQ25890 charger, paired with >> a TI BQ27520 fuelgauge, using the TI BQ25890 for BC1.2 charger type >> detection, for a USB-2 only Type-C port without PD. >> >> 3. The Lenovo Yoga Book YB1-X90 / Lenovo Yoga Book YB1-X91 series: >> >> The WC PMIC is connected to a TI BQ25892 charger, paired with >> a TI BQ27542 fuelgauge, using the WC PMIC for BC1.2 charger type >> detection and using the BQ25892's Mediatek Pump Express+ (1.0) >> >> ### >> >> Unlike what is normal on X86 this diversity in designs is not handled / >> abstracted away by the ACPI tables. > > I will briefly look into it, right now two observations (or nit-picks): Thank you. > - you may utilize Co-developed-by tag when it makes sense Right, I intended to do so in patch 13/20, but I now see that I somehow forgot that :) > - I would rather see "x86/ACPI" in all texts (note small "x") Ack. Regards, Hans