Date:   Tue, 16 Nov 2021 05:45:23 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Jiri Pirko <jiri@resnulli.us>
Cc:     Jason Gunthorpe <jgg@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        Jiri Pirko <jiri@nvidia.com>, Ido Schimmel <idosch@idosch.org>,
        "David S . Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        edwin.peer@broadcom.com
Subject: Re: [PATCH net-next] devlink: Require devlink lock during device
 reload
Message-ID: <20211116054523.16e7c01e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <YZNW+mtcXe2kjJlY@nanopsycho>
References: <20211109182427.GJ1740502@nvidia.com>
        <YY0G90fJpu/OtF8L@nanopsycho>
        <YY0J8IOLQBBhok2M@unreal>
        <YY4aEFkVuqR+vauw@nanopsycho>
        <YZCqVig9GQi/o1iz@unreal>
        <YZJCdSy+wzqlwrE2@nanopsycho>
        <20211115125359.GM2105516@nvidia.com>
        <YZJx8raQt+FkKaeY@nanopsycho>
        <20211115150931.GA2386342@nvidia.com>
        <20211115072206.72435d60@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <YZNW+mtcXe2kjJlY@nanopsycho>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 16 Nov 2021 08:00:10 +0100 Jiri Pirko wrote:
> >> It is not that we care about events in different namespaces, it is
> >> that rdma, like everything else, doesn't care about namespaces and
> >> wants events from the netdev no matter where it is located.  
> >
> >devlink now allows drivers to be net ns-aware, and they should 
> >obey if they declare support.  Can we add a flag / capability 
> >to devlink and make it an explicit opt-in for drivers who care?  
> 
> Looks kind of odd to me. It is also not possible for netdevice to say if
> it should be net namespace aware or not. The driver should not be the
> one to decide this.

NETIF_F_NETNS_LOCAL, but yeah, if it can be fixed that's obviously better.