Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA942C433EF for ; Tue, 16 Nov 2021 13:57:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC67C61B9F for ; Tue, 16 Nov 2021 13:57:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236952AbhKPOAU (ORCPT ); Tue, 16 Nov 2021 09:00:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:34164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236145AbhKPOAT (ORCPT ); Tue, 16 Nov 2021 09:00:19 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3296F61B98; Tue, 16 Nov 2021 13:57:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637071042; bh=HHtT1pWYVFIKaaLQb5hTL9vWxiHKQzHPIP2j3PuVyFA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZLuk3eR7gwjzTFme95YWRPvMd8gjS/AjVuatggxAg0o1mhMU5UGkDwRrPxtFYJueM HvbuGEQNwJCfgEECCxBOByZyDmvZ44zkaXnRRKST4w3Jv2DS+aHzRcx3IsN/vdb1Ra 4yFziTiPs7J9b3ipPfVmrj3q8n+AB2fU83HfHezM= Date: Tue, 16 Nov 2021 14:57:20 +0100 From: Greg Kroah-Hartman To: Andreas Gruenbacher Cc: Sasha Levin , LKML , stable , Mathieu Malaterre , Paul Mackerras , kvm-ppc@vger.kernel.org Subject: Re: [PATCH 5.4 063/355] powerpc/kvm: Fix kvm_use_magic_page Message-ID: References: <20211115165313.549179499@linuxfoundation.org> <20211115165315.847107930@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 16, 2021 at 02:54:10PM +0100, Andreas Gruenbacher wrote: > On Tue, Nov 16, 2021 at 1:54 AM Sasha Levin wrote: > > On Mon, Nov 15, 2021 at 06:47:41PM +0100, Andreas Gruenbacher wrote: > > >Greg, > > > > > >On Mon, Nov 15, 2021 at 6:10 PM Greg Kroah-Hartman > > > wrote: > > >> From: Andreas Gruenbacher > > >> > > >> commit 0c8eb2884a42d992c7726539328b7d3568f22143 upstream. > > >> > > >> When switching from __get_user to fault_in_pages_readable, commit > > >> 9f9eae5ce717 broke kvm_use_magic_page: like __get_user, > > >> fault_in_pages_readable returns 0 on success. > > > > > >I've not heard back from the maintainers about this patch so far, so > > >it would probably be safer to leave it out of stable for now. > > > > What do you mean exactly? It's upstream. > > Mathieu Malaterre broke this test in 2018 (commit 9f9eae5ce717) but > that wasn't noticed until now (commit 0c8eb2884a42). This means that > this fix probably isn't critical, so I shouldn't be backported. Then why did you tag it to be explicitly backported to all stable kernels newer than 4.18? We are just doing what you asked to be done here... confused, greg k-h