Date:   Tue, 16 Nov 2021 11:03:54 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To:     Marco Elver <elver@google.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
CC:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Fabian Hemmer <copy@copy.sh>, Ian Rogers <irogers@google.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        kasan-dev@googlegroups.com
Subject: Re: [PATCH] perf test: Add basic stress test for sigtrap handling
User-Agent: K-9 Mail for Android
In-Reply-To: <YZO4zVusjQ+zu9PJ@elver.google.com>
References: <20211115112822.4077224-1-elver@google.com> <YZOpSVOCXe0zWeRs@kernel.org> <YZO4zVusjQ+zu9PJ@elver.google.com>
Message-ID: <0683D134-7465-46A8-A3FF-2E2D9131BB3D@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On November 16, 2021 10:57:33 AM GMT-03:00, Marco Elver <elver@google=2Eco=
m> wrote:
>On Tue, Nov 16, 2021 at 09:51AM -0300, Arnaldo Carvalho de Melo wrote:
>> Em Mon, Nov 15, 2021 at 12:28:23PM +0100, Marco Elver escreveu:
>> > Add basic stress test for sigtrap handling as a perf tool built-in te=
st=2E
>> > This allows sanity checking the basic sigtrap functionality from with=
in
>> > the perf tool=2E
>>=20
>> Works as root:
>>=20
>> [root@five ~]# perf test sigtrap
>> 73: Sigtrap                                                         : O=
k
>> [root@five ~]
>>=20
>> Not for !root:
>[=2E=2E=2E]
>> FAILED sys_perf_event_open(): Permission denied
>> test child finished with -1
>> ---- end ----
>> Sigtrap: FAILED!
>
>Ah, that shouldn't be the case=2E It's missing exclude_kernel/hv, and thi=
s
>test should work just fine as non-root=2E Please squash the below as well=
=2E
>Let me know if you'd like a v2=2E

I'll squash

>
>Ack for your change printing errors as well=2E
>
>Thanks,
>-- Marco
>
>------ >8 ------
>
>From: Marco Elver <elver@google=2Ecom>
>Date: Tue, 16 Nov 2021 14:52:18 +0100
>Subject: [PATCH] fixup! perf test: Add basic stress test for sigtrap hand=
ling
>
>Exclude kernel/hypervisor so the test can run as non-root=2E
>
>Signed-off-by: Marco Elver <elver@google=2Ecom>
>---
> tools/perf/tests/sigtrap=2Ec | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/tools/perf/tests/sigtrap=2Ec b/tools/perf/tests/sigtrap=2Ec
>index febfa1609356=2E=2Ee566f855bf74 100644
>--- a/tools/perf/tests/sigtrap=2Ec
>+++ b/tools/perf/tests/sigtrap=2Ec
>@@ -46,6 +46,8 @@ static struct perf_event_attr make_event_attr(void)
> 		=2Eremove_on_exec =3D 1, /* Required by sigtrap=2E */
> 		=2Esigtrap	=3D 1, /* Request synchronous SIGTRAP on event=2E */
> 		=2Esig_data	=3D TEST_SIG_DATA,
>+		=2Eexclude_kernel =3D 1,
>+		=2Eexclude_hv	=3D 1,
> 	};
> 	return attr;
> }