Date:   Tue, 16 Nov 2021 11:44:21 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Marco Elver <elver@google.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Fabian Hemmer <copy@copy.sh>, Ian Rogers <irogers@google.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        kasan-dev@googlegroups.com
Subject: Re: [PATCH] perf test: Add basic stress test for sigtrap handling
Message-ID: <YZPDxTv7TwzYTOGU@kernel.org>
References: <20211115112822.4077224-1-elver@google.com>
 <YZOpSVOCXe0zWeRs@kernel.org>
 <YZO4zVusjQ+zu9PJ@elver.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YZO4zVusjQ+zu9PJ@elver.google.com>
Precedence: bulk

Em Tue, Nov 16, 2021 at 02:57:33PM +0100, Marco Elver escreveu:
> On Tue, Nov 16, 2021 at 09:51AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Nov 15, 2021 at 12:28:23PM +0100, Marco Elver escreveu:
> > > Add basic stress test for sigtrap handling as a perf tool built-in test.
> > > This allows sanity checking the basic sigtrap functionality from within
> > > the perf tool.
> > 
> > Works as root:
> > 
> > [root@five ~]# perf test sigtrap
> > 73: Sigtrap                                                         : Ok
> > [root@five ~]
> > 
> > Not for !root:
> [...]
> > FAILED sys_perf_event_open(): Permission denied
> > test child finished with -1
> > ---- end ----
> > Sigtrap: FAILED!
> 
> Ah, that shouldn't be the case. It's missing exclude_kernel/hv, and this
> test should work just fine as non-root. Please squash the below as well.
> Let me know if you'd like a v2.
> 
> Ack for your change printing errors as well.

Squashed, thanks!

- Arnaldo