Message-ID: <f80f3207-363d-51b7-4ae0-e4b8aeb2544b@suse.com>
Date:   Tue, 16 Nov 2021 15:55:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH] xen/privcmd: make option visible in Kconfig
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>
CC:     linux@weissschuh.net, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <20211116143323.18866-1-jgross@suse.com>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <20211116143323.18866-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aUic87nJrHWHGCLLQbOQWXJ3JM9dmq5SS34htK4YqxXX/xi48Gs6/4+G+3CE?=
 =?us-ascii?Q?kUXyQMsB9KTuwqehnDOlGy46oP/DvzO4n1PgK/ymnvo9OzlBnIPBNovROU5I?=
 =?us-ascii?Q?ZiT7k549MNKOKHQi1k9i+vpwHChmhalqsJVHhFylGCQNygq/wodFHCAgZd+L?=
 =?us-ascii?Q?lishlpjV7bNXrp/GEVcOXNPsrB1omENnkN8XTTMzJnrCVYLCbSKHRQ343SiM?=
 =?us-ascii?Q?8cf1MRribiuK5Sla7uBMBioNmgDuXczIfdd358o93/mxrVMvtY7YI/jkU43Y?=
 =?us-ascii?Q?RjUFIHicK4D3v6DwV/O/97KJa2YrDlQzEVR5FVInHV0KKbmWdRn0a25na2fN?=
 =?us-ascii?Q?3mLAFeTW16Qdcm9/NMSAIBLjPF4ACZHNpZn7alIA4V+UdMfXK5phEUYh+z3i?=
 =?us-ascii?Q?fYNt5gVY6svuylJFv1F60ASwAZHePszAtpc1PMaS6XPLYqJvcm43OqRXaKUV?=
 =?us-ascii?Q?g5dxc2+rBeF/MwT+UhC2cNmW61q+N3fUXUgy5vANmnVjIvPAZ1IT0OygUdOV?=
 =?us-ascii?Q?pBmPEpKxJv7iRAkVObrTxcvBNfma12qArd1wHn284GVBuERh44kKqFV8pZbg?=
 =?us-ascii?Q?cHoom4RPA47x7aFJAvyP5cQIM9/4yFauwe5hknZ0yDpTKejgPEpNkJQIlLYX?=
 =?us-ascii?Q?xUmaR8+s52o6xRtieAVCVrEN/Dv4SrjLDtZY2Ong8iwQba8AflQ1s/4yjO4V?=
 =?us-ascii?Q?Z6QOhhH9iytC5Qfz+uoHp1TCzuBagNUY2h3HDR5cimVI5csL75VFyHphMYtU?=
 =?us-ascii?Q?grXb7HusUpK9sA49XP9kA6kvOep5aPgo+WxR/P2Uo4Wsjlk+aEOG4eOB7fy/?=
 =?us-ascii?Q?Fwu5hD2KtU94xc7CW8zOBc2tfZnMciYsk8y+fP3Y+X9To+OSuNJv9fIdcsV7?=
 =?us-ascii?Q?dT9eBNeZaHNgyoxOjHsjS7yl85NmAuDsk+gKKuEfzw8wjXUTtVZVURTPI18g?=
 =?us-ascii?Q?2kDTpj2eUluiVf9V0hW7c7h5nVxyQRmX8IewM9iz6eFBrLf30yuhHx1XFa1Y?=
 =?us-ascii?Q?Td2+Hm5JT0dIfMAC/T1pBMsx6x8Uzt7EgeTafjBu1CRjRQc7+kZAR3I6MWp/?=
 =?us-ascii?Q?JEx+P+McJO/Xo911vgz0iT5ykHCj3QTNq9+vPmZri1q8/fXt2E2qi2oQ4zCX?=
 =?us-ascii?Q?Zxy5OCx0na8hICqHp4ZtspCeGUPmdwQZiV+8FWhxP75NTyHfS3Udg81XcLLv?=
 =?us-ascii?Q?0ubA1VS6y+blRsnrcoFQiTi5U/YObPHgQcjYDxNKi7XyqIGQFTo3iDKEOxPw?=
 =?us-ascii?Q?pX5PhQYCTB+RmoS7JqrQJ7+D1EaD9hPhEFlEqO2jZhlp2j1Qy8O7RzfdRRPT?=
 =?us-ascii?Q?nb7uGTcPlL4l4vx1rNTWGFqRdE20NmrcppkoFrxCdZINNizmKHIuQMuzF9x2?=
 =?us-ascii?Q?Zmk1vW4R4RX/Q77CQHuyY4apQSNogdFBZQpAvVbkIyBx77/9sSEu/OIf4J/2?=
 =?us-ascii?Q?bH6dDDOp0sUN8UQ9BctoKUn1uVpwznX0xbxy1IZvGiztszstiEdOldKZoBhV?=
 =?us-ascii?Q?b5xfseJNDIkCAYV4P6dg4WmaD47pnbXgHU94/tCd7IRqo+G2FbV2ZVDxVYWx?=
 =?us-ascii?Q?xPvIta1+jJMVFwBYywBT+wTn2DUXDzlsl69dseEQHJePHKAIhHTCxInE3hjO?=
 =?us-ascii?Q?nMsKECYZsZT8w/yH1U1JZY8=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 161156a7-bf84-42dc-d0af-08d9a911301d
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2021 14:55:53.7343
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BG/aUZ1+Um3YFUmljdLnsi2KZmnemH8biKt4tqI67Hmnor23bx0pqNP4RgPgHyOAAvX+6YKEQNW1R+ccETKziA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3117
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16.11.2021 15:33, Juergen Gross wrote:
> This configuration option provides a misc device as an API to userspace.
> Make this API usable without having to select the module as a transitive
> dependency.
>=20
> This also fixes an issue where localyesconfig would select
> CONFIG_XEN_PRIVCMD=3Dm because it was not visible and defaulted to
> building as module.
>=20
> Based-on-patch-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
> Signed-off-by: Juergen Gross <jgross@suse.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -259,9 +259,14 @@ config XEN_SCSI_BACKEND
>  	  if guests need generic access to SCSI devices.
> =20
>  config XEN_PRIVCMD
> -	tristate
> +	tristate "Xen hypercall passthrough driver"
>  	depends on XEN
>  	default m
> +	help
> +	  The hypercall passthrough driver allows user land programs to perform

Maybe worth adding "privileged" here? Albeit of course that's different
from the use of the word ...

> +	  Xen hypercalls. This driver is normally required for systems running
> +	  as Dom0 to perform privileged operations, but in some disaggregated

... here, so there'd be a small risk of confusion.

Jan

> +	  Xen setups this driver might be needed for other domains, too.
> =20
>  config XEN_ACPI_PROCESSOR
>  	tristate "Xen ACPI processor"
>=20