Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79661C433EF for ; Tue, 16 Nov 2021 14:59:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EA4A61C4F for ; Tue, 16 Nov 2021 14:59:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237735AbhKPPCP (ORCPT ); Tue, 16 Nov 2021 10:02:15 -0500 Received: from todd.t-8ch.de ([159.69.126.157]:35453 "EHLO todd.t-8ch.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233685AbhKPPCM (ORCPT ); Tue, 16 Nov 2021 10:02:12 -0500 Date: Tue, 16 Nov 2021 15:59:11 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1637074752; bh=cb2OUIDphqHIt9Wszcy0dU6ogQaVy9OblEb3njsk/BA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=B5PlIfWp5E08QiHGOMYxCuLCDfYIbCPJj9eaWw0rLFxzA7H9i21vDwkA0gIAt3OyX S96NinLjfE/a4cPxwZffSsOdNJllUyN1EQrpwBkYWzBRbafCNRsP52kPJBbFjDfkKs CcrSv9y00pONx+RkgMvF1gflACpgp/j6Edjvcj+E= From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, Boris Ostrovsky , Stefano Stabellini Subject: Re: [PATCH] xen/privcmd: make option visible in Kconfig Message-ID: References: <20211116143323.18866-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211116143323.18866-1-jgross@suse.com> Jabber-ID: thomas@t-8ch.de X-Accept: text/plain, text/html;q=0.2, text/*;q=0.1 X-Accept-Language: en-us, en;q=0.8, de-de;q=0.7, de;q=0.6 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks! On 2021-11-16 15:33+0100, Juergen Gross wrote: > This configuration option provides a misc device as an API to userspace. > Make this API usable without having to select the module as a transitive > dependency. > > This also fixes an issue where localyesconfig would select > CONFIG_XEN_PRIVCMD=m because it was not visible and defaulted to > building as module. > > Based-on-patch-by: Thomas Weißschuh > Signed-off-by: Juergen Gross > --- > drivers/xen/Kconfig | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index a1b11c62da9e..a2e91d3ca372 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -259,9 +259,14 @@ config XEN_SCSI_BACKEND > if guests need generic access to SCSI devices. > > config XEN_PRIVCMD > - tristate > + tristate "Xen hypercall passthrough driver" > depends on XEN > default m > + help > + The hypercall passthrough driver allows user land programs to perform > + Xen hypercalls. This driver is normally required for systems running > + as Dom0 to perform privileged operations, but in some disaggregated > + Xen setups this driver might be needed for other domains, too. > > config XEN_ACPI_PROCESSOR > tristate "Xen ACPI processor" > -- > 2.26.2 Reviewed-by: Thomas Weißschuh