Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965114AbXAJWRL (ORCPT ); Wed, 10 Jan 2007 17:17:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965119AbXAJWRL (ORCPT ); Wed, 10 Jan 2007 17:17:11 -0500 Received: from smtp.osdl.org ([65.172.181.24]:58441 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965114AbXAJWRJ (ORCPT ); Wed, 10 Jan 2007 17:17:09 -0500 Date: Wed, 10 Jan 2007 14:16:59 -0800 (PST) From: Linus Torvalds To: Geert Uytterhoeven cc: Peter Zijlstra , Andrew Morton , Al Viro , Linux Kernel Development , Linux/m68k Subject: Re: [PATCH] mm: pagefault_{disable,enable}() In-Reply-To: Message-ID: References: <200612071659.kB7GxGHa030259@hera.kernel.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1190 Lines: 29 On Wed, 10 Jan 2007, Geert Uytterhoeven wrote: > > This change causes lots of compile errors of the following form on m68k: > > | linux-2.6.20-rc4/include/linux/uaccess.h: In function `pagefault_disable': > | linux-2.6.20-rc4/include/linux/uaccess.h:18: error: dereferencing pointer to incomplete type > | linux-2.6.20-rc4/include/linux/uaccess.h: In function `pagefault_enable': > | linux-2.6.20-rc4/include/linux/uaccess.h:33: error: dereferencing pointer to incomplete type Ouch. However, I think your patch is bogus. You're fixing somethign that doesn't need fixing: already includes for the preemption functions. The REAL problem seems to be that the m68k preempt.h (or rather, to be exact, asm/thread_info.h) doesn't do things right, and while it exposes "inc_preempt_count()", it doesn't expose enough information to actually use it. I think your "current_thread_info()" is broken. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/