Message-ID: <2ced2fae-2ffd-3a70-f02c-175662baf7bc@redhat.com>
Date:   Tue, 16 Nov 2021 16:28:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH] fw_cfg: Fix memory leak in fw_cfg_register_file
Content-Language: en-US
To:     Miaoqian Lin <linmq006@gmail.com>, Qiushi Wu <wu000273@umn.edu>
Cc:     qemu-devel@nongnu.org, linux-kernel@vger.kernel.org,
        Gabriel Somlo <somlo@cmu.edu>,
        "Michael S. Tsirkin" <mst@redhat.com>
References: <20211116114233.29462-1-linmq006@gmail.com>
From:   =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@redhat.com>
In-Reply-To: <20211116114233.29462-1-linmq006@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 11/16/21 12:42, Miaoqian Lin wrote:
> When kobject_init_and_add() fails, entry should be freed just like
> when sysfs_create_bin_file() fails.
> 

Fixes: fe3c60684377 ("firmware: Fix a reference count leak.")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>  drivers/firmware/qemu_fw_cfg.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
> index 172c751a4f6c..0f404777f016 100644
> --- a/drivers/firmware/qemu_fw_cfg.c
> +++ b/drivers/firmware/qemu_fw_cfg.c
> @@ -608,6 +608,7 @@ static int fw_cfg_register_file(const struct fw_cfg_file *f)
>  				   fw_cfg_sel_ko, "%d", entry->select);
>  	if (err) {
>  		kobject_put(&entry->kobj);
> +		kfree(entry);
>  		return err;
>  	}
>  
>