Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965122AbXAJW22 (ORCPT ); Wed, 10 Jan 2007 17:28:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965133AbXAJW22 (ORCPT ); Wed, 10 Jan 2007 17:28:28 -0500 Received: from vervifontaine.sonytel.be ([80.88.33.193]:43939 "EHLO vervifontaine.sonycom.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S965122AbXAJW21 (ORCPT ); Wed, 10 Jan 2007 17:28:27 -0500 Date: Wed, 10 Jan 2007 23:28:20 +0100 (CET) From: Geert Uytterhoeven To: Linus Torvalds cc: Peter Zijlstra , Andrew Morton , Al Viro , Linux Kernel Development , Linux/m68k Subject: Re: [PATCH] mm: pagefault_{disable,enable}() In-Reply-To: Message-ID: References: <200612071659.kB7GxGHa030259@hera.kernel.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1895 Lines: 47 On Wed, 10 Jan 2007, Linus Torvalds wrote: > On Wed, 10 Jan 2007, Geert Uytterhoeven wrote: > > This change causes lots of compile errors of the following form on m68k: > > > > | linux-2.6.20-rc4/include/linux/uaccess.h: In function `pagefault_disable': > > | linux-2.6.20-rc4/include/linux/uaccess.h:18: error: dereferencing pointer to incomplete type > > | linux-2.6.20-rc4/include/linux/uaccess.h: In function `pagefault_enable': > > | linux-2.6.20-rc4/include/linux/uaccess.h:33: error: dereferencing pointer to incomplete type > > Ouch. However, I think your patch is bogus. > > You're fixing somethign that doesn't need fixing: > already includes for the preemption functions. Indeed. > The REAL problem seems to be that the m68k preempt.h (or rather, to be > exact, asm/thread_info.h) doesn't do things right, and while it exposes > "inc_preempt_count()", it doesn't expose enough information to actually > use it. > > I think your "current_thread_info()" is broken. But struct task_struct is defined in , which cannot be included in due to include recursion hell. The alternative is to move struct task_struct to its own file, which may be a bit too intrusive for 2.6.20. So I'm afraid my patch is the least intrusive solution. Or am I missing something? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/