Date:   Tue, 16 Nov 2021 16:43:38 +0100
From:   David Sterba <dsterba@suse.cz>
To:     dsterba@suse.cz, Linus Torvalds <torvalds@linux-foundation.org>,
        Qu Wenruo <wqu@suse.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>
Subject: Re: Kmap-related crashes and memory leaks on 32bit arch (5.15+)
Message-ID: <20211116154338.GQ28560@twin.jikos.cz>
Reply-To: dsterba@suse.cz
Mail-Followup-To: dsterba@suse.cz,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Qu Wenruo <wqu@suse.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>
References: <20211104115001.GU20319@twin.jikos.cz>
 <CAHk-=whYQvExYESEOJoSj4Jy7t+tSZgbCWuNpdwXYh+3zq2itw@mail.gmail.com>
 <CAHk-=whBOXM3mh-QtzK-EQtDEHQLcziAXu07KxU1crUc5jiQUg@mail.gmail.com>
 <20211105195004.GJ28560@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211105195004.GJ28560@suse.cz>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Precedence: bulk

On Fri, Nov 05, 2021 at 08:50:04PM +0100, David Sterba wrote:
> On Thu, Nov 04, 2021 at 04:37:25PM -0700, Linus Torvalds wrote:
> > On Thu, Nov 4, 2021 at 3:09 PM Linus Torvalds
> > <torvalds@linux-foundation.org> wrote:
> > > If (a) works, but (b) still fails, then it must be some odd
> > > interaction issug withs-----ing else. Which sounds unlikely, since I
> > > don't think we really had anything that should affect kmap or anything
> > > in this area, but who knows...
> > 
> > And bisection ends up perhaps somewhat painful, but sounds like the
> > way to go if there's no other path forward.
> 
> Just to give an update, I tested several merge commits and the btrfs
> merge is the first bad (037c50bfbeb33b4c).
> 
> Last good is the one right before that,
> 
> 9c6e8d52a7299  Merge tag 'exfat-for-5.16-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/exfat
> (plus the fixup to make it compile e66435936756d9bce)
> 
> The remaining test to do is the merge conflict resolved by me, as you
> suggested.

So the result is that the merge conflict from Linus resolved the kmaps
correctly, there was a bug in the lzo refactoring patch itself that
caused some page array overflow and some random address was accessed.

I'll send a pull request in a day, I've been validating the patch on the
unmerged base and on rc1, also with various debugging options on.
Curiously, with SLOB there's an early crash while still doing the
compression, but with SLUB (and debugging enabled) there is not an
immediate crash but some other warning/assertion notices a page with
mapping (unexpected).