MIME-Version: 1.0
References: <20211115133745.11445-1-johan@kernel.org> <20211115133745.11445-2-johan@kernel.org>
In-Reply-To: <20211115133745.11445-2-johan@kernel.org>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 16 Nov 2021 17:44:14 +0200
Message-ID: <CAHp75VeGinEWv0BuAsrHtif2b1p26uUEmSRqG4_y76vDdvNKAw@mail.gmail.com>
Subject: Re: [PATCH 1/3] serial: liteuart: fix compile testing
To:     Johan Hovold <johan@kernel.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ilia Sergachev <silia@ethz.ch>,
        Karol Gugala <kgugala@antmicro.com>,
        Mateusz Holenko <mholenko@antmicro.com>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Stable <stable@vger.kernel.org>,
        Filip Kokosinski <fkokosinski@antmicro.com>,
        Stafford Horne <shorne@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Nov 15, 2021 at 3:44 PM Johan Hovold <johan@kernel.org> wrote:
>
> Allow the liteuart driver to be compile tested by fixing the broken
> Kconfig dependencies.

...

>  config SERIAL_LITEUART
>         tristate "LiteUART serial port support"
> +       depends on LITEX || COMPILE_TEST
>         depends on HAS_IOMEM
> -       depends on OF || COMPILE_TEST
> -       depends on LITEX

> +       depends on OF

AFAICS this is optional and prevents compile testing in some cases.

>         select SERIAL_CORE
>         help
>           This driver is for the FPGA-based LiteUART serial controller from LiteX


-- 
With Best Regards,
Andy Shevchenko