Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8918C433F5 for ; Tue, 16 Nov 2021 16:14:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DF4C61881 for ; Tue, 16 Nov 2021 16:14:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230395AbhKPQQy (ORCPT ); Tue, 16 Nov 2021 11:16:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbhKPQQn (ORCPT ); Tue, 16 Nov 2021 11:16:43 -0500 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8B37C061570; Tue, 16 Nov 2021 08:13:46 -0800 (PST) Received: by mail-ed1-x52d.google.com with SMTP id e3so53835787edu.4; Tue, 16 Nov 2021 08:13:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=50QCkGUElk/jMFTX3H/2D+qJecjTCiwTPcIPrxs29UY=; b=lROBxbp6aw1lSJFZve0CLEi4r203O6x+xtEj4ordjC5YTDarvHSdJbgbfvOZeQ4ryQ dmel/Fomvo8b1w2IxT5JHIBLL9YmtpQBnc6aiL8Hpnhjn9y/Ms+zRyzsuXzsyi13N9B1 rCjjSDOCjdoezAhHLmxac+RjiU/GAIoHBGRc6R232naf75seKfUcJhXtso17EAfNKyrx udsHnKa59eMP4lZl2tuZzYuXUlAn2LOKugdb0ndhYuAugSN+nGtB40egxYe9nC62qJz4 fxWh0LgJ21Ig9tf8KDFyFN6bu4AiLlaRDjG/NhR5ixEMQ7LYwdvNKzwETWjwVedqr9cQ b7fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=50QCkGUElk/jMFTX3H/2D+qJecjTCiwTPcIPrxs29UY=; b=BnteWz4npiQu9ZxDyjqoOGOjvfhNQS3TdXk/4YxbNVN5nQ0moFJAflLmXxcSyG2sGj YKkysUYWrD6kwYIoieZDrDQZ58Tq8hO78CLgFlYkPhJ8OYn2DL6qfrwpT9qpOY5EsQb3 dy04Gdv6Daw/aY459U4JGIQAXE9BxC8pEhkibRLPknZ+9XhKtO/W8kC8ep5opSMKcskT z8zFn9r9oTC5/10vsKmqn9JTz9AzptsGOfZuhSO5cvURvMiLiaei3VT2xuK+/+bZTudA rg4Dqqrm4xbNrpgRCv3mU6mBOE8plTliIfJaR/EQvD+sNQn7pq7Sy0SS+GaOPO0mLcGn f0MA== X-Gm-Message-State: AOAM531ORE+a/4/jI9E99GnTP/YDXYwVHrKpnNCW9XADg8nJQ1DvQfW8 TlV4RHBLV5eQsONFOiIMxHq7ttVzUbGzDtPLFNw= X-Google-Smtp-Source: ABdhPJxz9YUq27598es1YhF6T5O+95wGFrkVO6obEtS3MnJuRp9PIA9hZgOWIYXzAalnrrOc/cFIJBlzV47JzYhjrgk= X-Received: by 2002:a17:906:6a0a:: with SMTP id qw10mr11823300ejc.141.1637079225318; Tue, 16 Nov 2021 08:13:45 -0800 (PST) MIME-Version: 1.0 References: <20211116150119.2171-1-kernel@esmil.dk> In-Reply-To: From: Andy Shevchenko Date: Tue, 16 Nov 2021 18:13:04 +0200 Message-ID: Subject: Re: [PATCH v4 00/16] Basic StarFive JH7100 RISC-V SoC support To: Arnd Bergmann Cc: Emil Renner Berthing , linux-riscv , DTML , linux-clk , "open list:GPIO SUBSYSTEM" , "open list:SERIAL DRIVERS" , Palmer Dabbelt , Paul Walmsley , Rob Herring , Michael Turquette , Stephen Boyd , Thomas Gleixner , Marc Zyngier , Philipp Zabel , Linus Walleij , Greg Kroah-Hartman , Daniel Lezcano , Andy Shevchenko , Jiri Slaby , Maximilian Luz , Sagar Kadam , Drew Fustini , Geert Uytterhoeven , Michael Zhu , Fu Wei , Anup Patel , Atish Patra , Matteo Croce , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 16, 2021 at 6:09 PM Arnd Bergmann wrote: > On Tue, Nov 16, 2021 at 4:01 PM Emil Renner Berthing wrote: ... > One general (minor) comment about the patches: please put your own > 'Signed-off-by' > into the last line of the patch description, below all the lines you > took from other people, so > instead of: > > | Signed-off-by: Emil Renner Berthing > | Reviewed-by: Geert Uytterhoeven > | Acked-by: Rob Herring > > do this: > > | Reviewed-by: Geert Uytterhoeven > | Acked-by: Rob Herring > | Signed-off-by: Emil Renner Berthing Why? Submitting Patches tells about chronological order and last SoB to be from the submitter. These both are correct. Note the difference between 'last SoB' and 'SoB to be last [line]'. Here is the excerpt: "Notably, the last Signed-off-by: must always be that of the developer submitting the patch." -- With Best Regards, Andy Shevchenko