Message-ID: <a0baf2b6-70f9-3185-cd92-d83533c63ff0@linaro.org>
Date:   Tue, 16 Nov 2021 08:40:49 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH] tipc: use consistent GFP flags
Content-Language: en-US
To:     patchwork-bot+netdevbpf@kernel.org,
        "David S. Miller" <davem@davemloft.net>
Cc:     jmaloy@redhat.com, ying.xue@windriver.com, davem@davemloft.net,
        kuba@kernel.org, netdev@vger.kernel.org,
        tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org
References: <20211111205916.37899-2-tadeusz.struk@linaro.org>
 <163698120846.10163.14371622974741533436.git-patchwork-notify@kernel.org>
From:   Tadeusz Struk <tadeusz.struk@linaro.org>
In-Reply-To: <163698120846.10163.14371622974741533436.git-patchwork-notify@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/15/21 05:00, patchwork-bot+netdevbpf@kernel.org wrote:
> This patch was applied to netdev/net.git (master)
> by David S. Miller<davem@davemloft.net>:
> 
> On Thu, 11 Nov 2021 12:59:16 -0800 you wrote:
>> Some functions, like tipc_crypto_start use inconsisten GFP flags
>> when allocating memory. The mentioned function use GFP_ATOMIC to
>> to alloc a crypto instance, and then calls alloc_ordered_workqueue()
>> which allocates memory with GFP_KERNEL. tipc_aead_init() function
>> even uses GFP_KERNEL and GFP_ATOMIC interchangeably.
>> No doc comment specifies what context a function is designed to
>> work in, but the flags should at least be consistent within a function.
>>
>> [...]
> Here is the summary with links:
>    - tipc: use consistent GFP flags
>      https://git.kernel.org/netdev/net/c/86c3a3e964d9
> 
> You are awesome, thank you!

Thanks, you are awesome too! ;)
Any feedback about the patch:
[PATCH v2] tipc: check for null after calling kmemdup

-- 
Thanks,
Tadeusz