Message-ID: <ce7f36b6-fa4f-f6a4-a055-28893069cfa0@intel.com>
Date:   Tue, 16 Nov 2021 18:19:46 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.3.0
Subject: Re: 32bit x86 build broken (was: Re: [GIT PULL] Networking for
 5.16-rc1)
Content-Language: en-US
To:     Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "Daniel Lezcano" <daniel.lezcano@linaro.org>
CC:     David Miller <davem@davemloft.net>,
        Netdev <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        bpf <bpf@vger.kernel.org>,
        NetFilter <netfilter-devel@vger.kernel.org>,
        <linux-can@vger.kernel.org>
References: <20211111163301.1930617-1-kuba@kernel.org>
 <163667214755.13198.7575893429746378949.pr-tracker-bot@kernel.org>
 <20211111174654.3d1f83e3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <CAHk-=wiNEdrLirAbHwJvmp_s2Kjjd5eV680hTZnbBT2gXK4QbQ@mail.gmail.com>
 <20211112063355.16cb9d3b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <9999b559abecea2eeb72b0b6973a31fcd39087c1.camel@linux.intel.com>
From:   "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego
 173, 80-298 Gdansk
In-Reply-To: <9999b559abecea2eeb72b0b6973a31fcd39087c1.camel@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bCswNHM4aUM5MEhsWHByZVUzbTJMMHhNWUlVMTNMbElzNHpTZ1dSNGRFTDBL?=
 =?utf-8?B?L0FZT1BSSWJVc21Ba29HOVZjalRTdlFQREpVZ2YzWXY1N0xZWFVWcmhrVXI4?=
 =?utf-8?B?dlkxUktHT0tjdTU2bXV1bkppdEhBb0FTUnJ3eFg0WHgyWGdJU0ZFdHI0Y3Mz?=
 =?utf-8?B?NTlLOTFLeURqNU8rNnZxcVF2NVhudFJUVmxhb2RJb1hwSnd6OG1KWU41RERi?=
 =?utf-8?B?c2RYM1RFNmhKYXlqcUMxRXg0NDAvRUlRbHJHUWJmdlc3Q0pCZENuTkxJOUNu?=
 =?utf-8?B?WVRLRHVBTmNrZmJFY1VLZGw2N1I0RlpVT0tSRVVma3QzNkM3Y08vMVY1L3Vx?=
 =?utf-8?B?VHBkb3orTTV0OWl5YStmV0lWMkhXNGlHeFlRLzI4Z0MxZVJWUkwwUmNzR1Av?=
 =?utf-8?B?QmZ6YUVCZGJ6THVTUHdyYUY0RXl2LytjMUJPcVJPSG4xZzFja20rUVYvbGV1?=
 =?utf-8?B?dzFlbENLMHBlcnVhMUNOeEhMZHh2ZVFVSHNRcW9VTzYzTXVNMHEvQnQ5YUdy?=
 =?utf-8?B?dVhzUkZ4b1FieHRiVTJIcUZoVENTc1VsS3RWd0c1T094dmhyZHJLSml4MDE5?=
 =?utf-8?B?MzU5c1Nib2V4Rkt0VmFJaUg1YjdUVUVUOXZNd1VMVVlIbGNNNzhpKzI1cmJP?=
 =?utf-8?B?bjlQeDZQV1lnZjh1RWt3OVBOODhWL3J4Y0VkUUFrSDU4cDdTL2o0QXhQRE9k?=
 =?utf-8?B?K2N4SU1WNkRGbnl5bkxEb2k3L08zQXdZVzBhQzNuQXR3TDNZTUt5UklZSXJM?=
 =?utf-8?B?Z2tLdE9QWXlTNFNSakozL0JLSStlcWh6cUtQajJDeTFFcjBnSXFBb1ZBU2sr?=
 =?utf-8?B?SDAzMkdzZUxZclFSUEI5eUdyVDVrSG0wU05OeUFvR0sva2tCZk45V1hKTFV1?=
 =?utf-8?B?aXdXcWt4VVNJSW1hUlh3cXV0QnlCWlZBZFdSRUYxMm1tRnNLMDluWDVqeEN0?=
 =?utf-8?B?YndqbG94NldLUU9UMDJ3dTBIYUUvVldWMmEvaWR0MC9MUXVFM2E4MTNuWE1h?=
 =?utf-8?B?OEIvTXhuZG5uOFI4TTV4TDkwb3BlOWdncVhVVXNmSENTODBPNGpYdm9vQ1d1?=
 =?utf-8?B?ME4reWk3eVc3b2lzc01laGtkeFVrWHhCTzN2ZXhzZjlGUHNaUURUMjBMSkJJ?=
 =?utf-8?B?cUxxOHRpUVJnSmhUYVBuMkloR1pPSmlRYWtFend6K1puTDNQV2xoMHFiT1NO?=
 =?utf-8?B?R202d3lXcWRHU2hKeFRZci9FY1Q2V2YxaEZYRXV3ellzbFA4R1A2cHlVZytR?=
 =?utf-8?B?bmFLc2tXV0x6Q0JlZzJOL2o3VFBIS09hUXdXdGFHVDNuR2wxQ000MjBDY3ll?=
 =?utf-8?B?Q2l4dHJrWmh6UjYwaUJsL2VWb2I0MFBKdUtEVGRhSzVIdTZTa1pXMzJVeUh2?=
 =?utf-8?B?akhPUHhCKzlGUDdSRndPVVN0QVAzTUVDNUFsMmZFdW5JWGJraGtEVG92ZXBs?=
 =?utf-8?B?ZUhHYXZIZW1UWFZEN2R2b21nYVlvTzgyVTFrN20xQ0hCWS9zWjVFYlR4cTQ0?=
 =?utf-8?B?ZTJKeElYU3ZkSi9EWGRLNSt4bmdWRkRFeW55ZHhyOUgvSHJwWjNRVS9Fa3Rz?=
 =?utf-8?B?dmplNjBrOE5SL2FHdFJsM2RvZHFicDZRUWd6YStmdXFGbUttd2JlMEpPa2hT?=
 =?utf-8?B?UHB5Vk1aZmQ1RHlGRHRmaWVxK2ZaSm1XY1A5SDEyc1ZoMnkyUFFKMHlCZXRD?=
 =?utf-8?B?Y09rbVlnRXVKMGU2ZXE4L0pIQmhBcnFHVUUrQlZJRzRXMHo1VXJkQnBFcnNH?=
 =?utf-8?B?MEdYTHplN2pUOVZQVE5jN0dER2UxTFlENTZyUzdibkZMWGFCcHdyNm9hNENR?=
 =?utf-8?B?RWk3VlB2SzBFWkwvMmNKZkd0aWVmazgrNXlLUnU3MTFnWDh0WXVFTkFiSEhk?=
 =?utf-8?B?bjJvNGNkOUxwNU9RU0R6ZnpGL1ExVmFpVlJrbWlDcU1XK24rdGxTMDFTTFBW?=
 =?utf-8?B?MGFsVTNlNU9SNmRZRVVZSEJMS0JpNzFzNU1nZXpIMDJKYkhFcXJDcW5YY05m?=
 =?utf-8?B?VE1tcWp5amV2R2lFUDJHUU14eURWa0FYbkNLUTJielFYSUxhdXYyMitQOTR2?=
 =?utf-8?B?bW1QU0wweVc1WHJUaTFrYUp6SGs5VUFQK2ZlbGdUTkpvZVpLOFFkVmtBcm4y?=
 =?utf-8?B?THdKQUo0NnhoSU5HbTA0RlZjOVZPVWsyWk40Y3UwRVhubDBpR3FKSlBJNlUr?=
 =?utf-8?B?cGdVaWdOTm83NWppVGtESnh2OXl5U29uM25ucjRaRmR3Qy9ndEZpUFRaMDJO?=
 =?utf-8?Q?SewpFPfwlnyYy6XP0/yxbNGneXrX5zjR6bBXCuRbc8=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d19ce72c-2b8f-454e-fb7f-08d9a9254d0c
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5326.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2021 17:19:52.2839
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: obQdnXBFobnqYw+7ujxyhBkIEk0uWVVsEqeOlJeU7Bgbkw5Bq/MDoFU81yaS/G49DnLmri2AvoC9xw/8Ck7lz+bQLzac5/8/+9jxk/eHKTs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4706
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/12/2021 4:04 PM, Srinivas Pandruvada wrote:
> On Fri, 2021-11-12 at 06:33 -0800, Jakub Kicinski wrote:
>> On Thu, 11 Nov 2021 18:48:43 -0800 Linus Torvalds wrote:
>>> On Thu, Nov 11, 2021 at 5:46 PM Jakub Kicinski <kuba@kernel.org>
>>> wrote:
>>>> Rafael, Srinivas, we're getting 32 bit build failures after pulling
>>>> back
>>>> from Linus today.
>>>>
>>>> make[1]: *** [/home/nipa/net/Makefile:1850: drivers] Error 2
>>>> make: *** [Makefile:219: __sub-make] Error 2
>>>> ../drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:
>>>> In function ‘send_mbox_cmd’:
>>>> ../drivers/thermal/intel/int340x_thermal/processor_thermal_mbox.c:7
>>>> 9:37: error: implicit declaration of function ‘readq’; did you mean
>>>> ‘readl’? [-Werror=implicit-function-declaration]
>>>>     79 |                         *cmd_resp = readq((void __iomem *)
>>>> (proc_priv->mmio_base + MBOX_OFFSET_DATA));
>>>>        |                                     ^~~~~
>>>>        |                                     readl
>>> Gaah.
>>>
>>> The trivial fix is *probably* just a simple
>> To be sure - are you planning to wait for the fix to come via
>> the usual path?  We can hold applying new patches to net on the
>> off chance that you'd apply the fix directly and we can fast
>> forward again :)
>>
>> Not that 32bit x86 matters all that much in practice, it's just
>> for preventing new errors (64b divs, mostly) from sneaking in.
>>
>> I'm guessing Rafeal may be AFK for the independence day weekend.
> He was off, but not sure if he is back. I requested Daniel to send PULL
> request for
> https://lore.kernel.org/lkml/a22a1eeb-c7a0-74c1-46e2-0a7bada73520@infradead.org/T/
>
>
>
Sorry for the delay, I'd been offline for the last few days.

I'm back now and I will be picking up the Arnd's patch shortly even 
though the simple fix is already there.