Date:   Tue, 16 Nov 2021 11:33:16 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Tadeusz Struk <tadeusz.struk@linaro.org>
Cc:     Jon Maloy <jmaloy@redhat.com>, Ying Xue <ying.xue@windriver.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        tipc-discussion@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH] tipc: check for null after calling kmemdup
Message-ID: <20211116113316.00d7d8cb@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20211116113232.45eceecf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
References: <20211111205916.37899-1-tadeusz.struk@linaro.org>
        <0f144d68-37c8-1e4a-1516-a3a572f06f8f@redhat.com>
        <20211112201332.601b8646@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <997876b6-39b4-64f0-648a-8b042b03a3a8@linaro.org>
        <20211116113232.45eceecf@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 16 Nov 2021 11:32:32 -0800 Jakub Kicinski wrote:
> On Fri, 12 Nov 2021 21:42:11 -0800 Tadeusz Struk wrote:
> > On 11/12/21 20:13, Jakub Kicinski wrote:
> >  [...]    
>  [...]  
> > > Hm, shouldn't we free all the tfm entries here?    
> > 
> > Right, I think we just need to call tipc_aead_free(&tmp->rcu);
> > here and return an error.  
> 
> Would be good to get an ack From Jon or Ying on that one.

Ah, I hit reply on the wrong sub-thread, this was meant for the "any
feedback question".