Message-ID: <7d7de7ce5b6e6ab4ae497495f86ad65d86a613dc.camel@kernel.org>
Subject: Re: [PATCH v2 1/2] tracing: Add helper functions to simplify
 event_command callback handling
From:   Tom Zanussi <zanussi@kernel.org>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     mhiramat@kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 16 Nov 2021 15:59:01 -0600
In-Reply-To: <20211116164120.0db8212b@gandalf.local.home>
References: <cover.1636748267.git.zanussi@kernel.org>
         <2b228845d7aa0466702ffc93db5f22bd6252c43b.1636748267.git.zanussi@kernel.org>
         <20211116164120.0db8212b@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2021-11-16 at 16:41 -0500, Steven Rostedt wrote:
> On Fri, 12 Nov 2021 14:23:39 -0600
> Tom Zanussi <zanussi@kernel.org> wrote:
> 
> >  
> > +int event_trigger_check(char *glob, char **trigger, char **param,
> > +			bool *remove, bool require_param, bool
> > separate_trigger)
> 
> All these functions are going to require having kerneldoc comments
> for
> them. I rather not have to try to figure out what these functions are
> for
> and just read the documentation.

Yeah, that make sense, will add documention for each one in the next
version.

Thanks,

Tom

> 
> -- Steve
> 
> 
> > +{
> > +	int ret = 0;
> > +
> > +	*remove = (glob && glob[0] == '!') ? true : false;
> > +